Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFD 56: SQL Backend #10253

Merged
merged 4 commits into from
Mar 4, 2022
Merged

RFD 56: SQL Backend #10253

merged 4 commits into from
Mar 4, 2022

Conversation

jimbishopp
Copy link
Contributor

@jimbishopp jimbishopp commented Feb 9, 2022

This PR adds an RFD describing requirements for the implementation of a PostgreSQL and CockroachDB backend supporting both self-hosted and cloud-hosted configurations.

@jimbishopp jimbishopp self-assigned this Feb 9, 2022
@jimbishopp jimbishopp force-pushed the rfd/0056-roachbackend branch 2 times, most recently from e7226cd to f5f9de9 Compare February 9, 2022 18:25
@jimbishopp jimbishopp added the rfd Request for Discussion label Feb 9, 2022
@jimbishopp jimbishopp force-pushed the rfd/0056-roachbackend branch from f5f9de9 to 317a716 Compare February 9, 2022 20:48
@jimbishopp jimbishopp requested a review from r0mant February 9, 2022 22:34
rfd/0056-cockroach-backend.md Outdated Show resolved Hide resolved
rfd/0056-cockroach-backend.md Outdated Show resolved Hide resolved
rfd/0056-cockroach-backend.md Outdated Show resolved Hide resolved
rfd/0056-cockroach-backend.md Outdated Show resolved Hide resolved
rfd/0056-cockroach-backend.md Outdated Show resolved Hide resolved
@jimbishopp jimbishopp force-pushed the rfd/0056-roachbackend branch from 3c31447 to 6ac23b0 Compare February 11, 2022 20:48
@jimbishopp jimbishopp changed the title RFD 56: CockroachDB Backend RFD 56: SQL Backend Feb 11, 2022
@jimbishopp jimbishopp force-pushed the rfd/0056-roachbackend branch from 46d875f to 5c99e09 Compare February 11, 2022 21:07
@jimbishopp jimbishopp requested a review from r0mant February 11, 2022 21:08
@jimbishopp jimbishopp marked this pull request as ready for review February 14, 2022 22:29
@github-actions github-actions bot requested review from Tener and zmb3 February 14, 2022 22:29
@jimbishopp jimbishopp removed request for Tener and zmb3 February 14, 2022 22:33
rfd/0056-sql-backend.md Show resolved Hide resolved
rfd/0056-sql-backend.md Outdated Show resolved Hide resolved
rfd/0056-sql-backend.md Show resolved Hide resolved
@jimbishopp jimbishopp force-pushed the rfd/0056-roachbackend branch 2 times, most recently from 65cc0a7 to 92a2344 Compare February 15, 2022 22:29
@jimbishopp jimbishopp enabled auto-merge (squash) February 15, 2022 22:35
@jimbishopp jimbishopp force-pushed the rfd/0056-roachbackend branch from 55cef5d to e67d5ca Compare February 16, 2022 22:50
rfd/0056-sql-backend.md Outdated Show resolved Hide resolved
rfd/0056-sql-backend.md Outdated Show resolved Hide resolved
rfd/0056-sql-backend.md Outdated Show resolved Hide resolved
@jimbishopp jimbishopp force-pushed the rfd/0056-roachbackend branch 2 times, most recently from 8cefdc3 to d06b844 Compare February 20, 2022 21:11
@jimbishopp jimbishopp force-pushed the rfd/0056-roachbackend branch from d06b844 to cfc8818 Compare February 20, 2022 21:14
@jimbishopp
Copy link
Contributor Author

Updated the RFD based on feedback and added a section about transaction isolation levels.

@jimbishopp jimbishopp requested a review from zmb3 February 20, 2022 21:20
@jimbishopp jimbishopp disabled auto-merge March 2, 2022 22:55
@jimbishopp jimbishopp enabled auto-merge (squash) March 4, 2022 15:42
@jimbishopp jimbishopp merged commit 512957a into master Mar 4, 2022
@jimbishopp jimbishopp deleted the rfd/0056-roachbackend branch March 4, 2022 15:46
@jimbishopp jimbishopp mentioned this pull request Mar 10, 2022
jimbishopp added a commit that referenced this pull request Mar 29, 2022
Add a new backend supporting PostgreSQL and CockroachDB. 

Implements #10253 without cloud connectivity.
jimbishopp added a commit that referenced this pull request Apr 1, 2022
Original PR: #11048

Add a new backend supporting PostgreSQL and CockroachDB.

Implements #10253 without cloud connectivity.
jimbishopp added a commit that referenced this pull request Apr 6, 2022
Original PR: #11048

Add a new backend supporting PostgreSQL and CockroachDB.

Implements #10253 without cloud connectivity.
jimbishopp added a commit that referenced this pull request Apr 6, 2022
Remove migration from backend API (#10835)

The Migrate method on the Backend interface was not implemented by any
backends.

Migration should be implemented in the New method of backends so they
can be sure migration happens before any background processes are
started.


Backport SQL Backend to v9

Original PR: #11048

Add a new backend supporting PostgreSQL and CockroachDB.

Implements #10253 without cloud connectivity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfd Request for Discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants