-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFD 56: SQL Backend #10253
Merged
Merged
RFD 56: SQL Backend #10253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimbishopp
force-pushed
the
rfd/0056-roachbackend
branch
2 times, most recently
from
February 9, 2022 18:25
e7226cd
to
f5f9de9
Compare
jimbishopp
force-pushed
the
rfd/0056-roachbackend
branch
from
February 9, 2022 20:48
f5f9de9
to
317a716
Compare
r0mant
reviewed
Feb 9, 2022
jimbishopp
force-pushed
the
rfd/0056-roachbackend
branch
from
February 11, 2022 20:48
3c31447
to
6ac23b0
Compare
jimbishopp
force-pushed
the
rfd/0056-roachbackend
branch
from
February 11, 2022 21:07
46d875f
to
5c99e09
Compare
jimbishopp
commented
Feb 14, 2022
r0mant
reviewed
Feb 15, 2022
jimbishopp
force-pushed
the
rfd/0056-roachbackend
branch
2 times, most recently
from
February 15, 2022 22:29
65cc0a7
to
92a2344
Compare
jimbishopp
force-pushed
the
rfd/0056-roachbackend
branch
from
February 16, 2022 22:50
55cef5d
to
e67d5ca
Compare
zmb3
reviewed
Feb 18, 2022
jimbishopp
force-pushed
the
rfd/0056-roachbackend
branch
2 times, most recently
from
February 20, 2022 21:11
8cefdc3
to
d06b844
Compare
jimbishopp
force-pushed
the
rfd/0056-roachbackend
branch
from
February 20, 2022 21:14
d06b844
to
cfc8818
Compare
Updated the RFD based on feedback and added a section about transaction isolation levels. |
zmb3
approved these changes
Mar 2, 2022
r0mant
approved these changes
Mar 4, 2022
Merged
jimbishopp
added a commit
that referenced
this pull request
Mar 29, 2022
Add a new backend supporting PostgreSQL and CockroachDB. Implements #10253 without cloud connectivity.
jimbishopp
added a commit
that referenced
this pull request
Apr 6, 2022
Remove migration from backend API (#10835) The Migrate method on the Backend interface was not implemented by any backends. Migration should be implemented in the New method of backends so they can be sure migration happens before any background processes are started. Backport SQL Backend to v9 Original PR: #11048 Add a new backend supporting PostgreSQL and CockroachDB. Implements #10253 without cloud connectivity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an RFD describing requirements for the implementation of a PostgreSQL and CockroachDB backend supporting both self-hosted and cloud-hosted configurations.