[v7] Backport #10735: Fix MOTD not showing up on tsh login with certain arguments #11372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxea
changed the title
lxea
changed the title
r0mant
approved these changes
Mar 23, 2022
zmb3
approved these changes
Mar 23, 2022
jakule
approved these changes
Mar 23, 2022
lxea
force-pushed
the
lxea/motd-inconsistency-v7
branch
from
f08ab60 to
6d9500b
Compare
added 2 commits
March 28, 2022 11:31
- changes to configuration.go: fixes tsh login in first test case `tsh login --insecure --proxy=127.0.0.1:3080 --user=test` - changes to apiserver.go fixes `--auth` not showing motd
Part of this includes renaming export_test.go to export.go so I could test the MOTD outside of lib/client/export.go
lxea
force-pushed
the
lxea/motd-inconsistency-v7
branch
from
6d9500b to
456f966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #10735