Fix MOTD not showing up on tsh login with certain arguments #10735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tsh
r0mant
reviewed
Mar 2, 2022
lxea
force-pushed
the
lxea/motd-inconsistency
branch
2 times, most recently
from
249c481 to
07112fd
Compare
r0mant
reviewed
Mar 8, 2022
lxea
force-pushed
the
lxea/motd-inconsistency
branch
from
07112fd to
257616a
Compare
r0mant
approved these changes
Mar 15, 2022
lxea
force-pushed
the
lxea/motd-inconsistency
branch
from
257616a to
5e4cac9
Compare
added 2 commits
March 15, 2022 11:54
- changes to configuration.go: fixes tsh login in first test case `tsh login --insecure --proxy=127.0.0.1:3080 --user=test` - changes to apiserver.go fixes `--auth` not showing motd
Part of this includes renaming export_test.go to export.go so I could test the MOTD outside of lib/client/export.go
lxea
force-pushed
the
lxea/motd-inconsistency
branch
from
5e4cac9 to
50e7db8
Compare
This was referenced Mar 23, 2022
lxea
pushed a commit
that referenced
this pull request
Mar 28, 2022
…in arguments (#11372) * Fix MOTD not showing up on tsh login with certain arguments - changes to configuration.go: fixes tsh login in first test case `tsh login --insecure --proxy=127.0.0.1:3080 --user=test` - changes to apiserver.go fixes `--auth` not showing motd * Add tests for motd fixes Part of this includes renaming export_test.go to export.go so I could test the MOTD outside of lib/client/export.go
lxea
pushed a commit
that referenced
this pull request
Mar 28, 2022
…in arguments (#11371) * Fix MOTD not showing up on tsh login with certain arguments - changes to configuration.go: fixes tsh login in first test case `tsh login --insecure --proxy=127.0.0.1:3080 --user=test` - changes to apiserver.go fixes `--auth` not showing motd * Add tests for motd fixes Part of this includes renaming export_test.go to export.go so I could test the MOTD outside of lib/client/export.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsh login --insecure --proxy=127.0.0.1:3080 --user=test--authand--with-rolesnot showing motdThese changes also add a test and part of that required moving
export_test.gotoexport.goso thepasswordFromConsolefunction could be overridden when testing for the MOTDfixes: #10503