[v9] Add endpoint to webapi to generate DB join token (#10914) #11256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add endpoint to generate join tokens with any roles
github-actions
bot
requested review from
codingllama,
fspmarshall,
hatched,
lxea,
r0mant and
zmb3
codingllama
changed the title
codingllama
approved these changes
Mar 18, 2022
r0mant
reviewed
Mar 18, 2022
lib/web/join_tokens.go
Outdated
| func (h *Handler) createTokenHandle(w http.ResponseWriter, r *http.Request, params httprouter.Params, ctx *SessionContext) (interface{}, error) { | ||
| var req createTokenRequest | ||
| if err := httplib.ReadJSON(r, &req); err != nil { | ||
| log.WithError(err).Error("error reading body") |
There was a problem hiding this comment.
Same comment as in the other backport, these errors should be logged by the caller.
There was a problem hiding this comment.
Thanks, removed on 8679f54
hatched
approved these changes
Mar 21, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #10914
Add endpoint to generate join tokens with any roles