Add endpoint to webapi to generate DB join token #10914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbattirola
changed the title
mcbattirola
changed the title
mcbattirola
commented
Mar 9, 2022
codingllama
reviewed
Mar 10, 2022
…ional/teleport into matheus/simplify-manual-db-join
codingllama
approved these changes
Mar 11, 2022
…us/simplify-manual-db-join
…us/simplify-manual-db-join
…ional/teleport into matheus/simplify-manual-db-join
|
@codingllama @zmb3 PTAL, thanks |
zmb3
approved these changes
Mar 14, 2022
mcbattirola
added a commit
that referenced
this pull request
Mar 18, 2022
* Add endpoint to generate join tokens with any roles
mcbattirola
added a commit
that referenced
this pull request
Mar 18, 2022
* Add endpoint to generate join tokens with any roles
mcbattirola
added a commit
that referenced
this pull request
Mar 23, 2022
mcbattirola
added a commit
that referenced
this pull request
Mar 23, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add a new endpoint that creates DB join tokens in the web API.
To simplify DB manual steps, we want to have a join token on the web UI, so the user doesn't have to generate it via
tctl tokens add --type=db.There is already an endpoint to get a join token to apps and nodes, now we're adding it for databases.
Changes:
/webapi/databases/tokencreateScriptJoinTokentocreateJoinToken, since it just returns a token, without relation to any script necessarilycreateJoinTokennow receives a list of roles to create tokens to, instead of always creating for app and nodeHere is the PR on
gravitational/webappsthat consumes this endpoint: gravitational/webapps#653Part of #10340