-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metric to track number ssh connect attempts #11240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm accustomed to seeing related metrics like this have names that are more similar.
I recognize we're limited by the original metric, but ideally we would have something like:
teleport_connect_to_node_attempts_failed
teleport_connect_to_node_attempts_total
Since we don't want to change the original metric, I wonder if we could at least update the Help
field or the docs so that these metrics mention each other.
Updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of very minor nits.
* add ssh connect attempts metric * fix help message wording Co-authored-by: Paul Gottschling <[email protected]>
This adds the metric
teleport_connect_to_node_attempts_total
This is added so that we can track percentage of successful connections as we already track failed attempts with
failed_connect_to_node_attempts_total