Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9] skip databases that are not available during auto discovery (#10699) #10870

Merged
merged 2 commits into from
Mar 8, 2022
Merged

[v9] skip databases that are not available during auto discovery (#10699) #10870

merged 2 commits into from
Mar 8, 2022

Conversation

greedy52
Copy link
Contributor

@greedy52 greedy52 commented Mar 4, 2022

@greedy52 greedy52 requested review from Tener, r0mant and smallinsky March 4, 2022 21:29
@greedy52 greedy52 self-assigned this Mar 4, 2022
@github-actions github-actions bot requested review from atburke and rosstimothy March 4, 2022 21:29
@github-actions github-actions bot added the database-access Database access related issues and PRs label Mar 4, 2022
@greedy52
Copy link
Contributor Author

greedy52 commented Mar 4, 2022

I think this is more an enhancement than a bug fix. Do you think we need to backport to v7/v8?

@Tener
Copy link
Contributor

Tener commented Mar 8, 2022

I'm not 100% we need to backport this to v9, but it looks useful so perhaps yes.

r0mant
r0mant approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greedy52 Can you backport to v8 too?

@greedy52 greedy52 enabled auto-merge (squash) March 8, 2022 19:45
@greedy52 greedy52 merged commit 47dfc67 into branch/v9 Mar 8, 2022
@greedy52 greedy52 deleted the STeve/backport/v9/10699 branch March 8, 2022 20:35
@webvictim webvictim mentioned this pull request Apr 19, 2022
Closed
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0mant r0mant r0mant approved these changes

@Tener Tener Tener approved these changes

@smallinsky smallinsky Awaiting requested review from smallinsky

@atburke atburke Awaiting requested review from atburke

@rosstimothy rosstimothy Awaiting requested review from rosstimothy

Assignees

@greedy52 greedy52

Labels
backport database-access Database access related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greedy52 @Tener @r0mant