skip databases that are not available during auto discovery #10699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greedy52
added
aws
r0mant
approved these changes
Mar 3, 2022
lib/services/database.go
Outdated
| // https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/accessing-monitoring.html | ||
| switch aws.StringValue(instance.DBInstanceStatus) { | ||
|
|
||
| // Statues marked as "Not billed" in the above guide. |
There was a problem hiding this comment.
Suggested change
| // Statues marked as "Not billed" in the above guide. | |
| // Statuses marked as "Not billed" in the above guide. |
Tener
reviewed
Mar 4, 2022
| @@ -44,14 +44,17 @@ func TestWatcher(t *testing.T) { | |||
| rdsInstance2, _ := makeRDSInstance(t, "instance-2", "us-east-2", map[string]string{"env": "prod"}) | |||
| rdsInstance3, _ := makeRDSInstance(t, "instance-3", "us-east-1", map[string]string{"env": "dev"}) | |||
| rdsInstance4, rdsDatabase4 := makeRDSInstance(t, "instance-4", "us-west-1", nil) | |||
| rdsInstanceUnavailable, _ := makeRDSInstance(t, "instance-5", "us-west-1", nil, rdsInstanceStatus("stopped")) | |||
There was a problem hiding this comment.
How about adding a test that explicitly verifies the behavior against unrecognized status, like "xxx-this-status-does-not-exist"?
There was a problem hiding this comment.
added
=== RUN TestWatcher/RDS_unavailable_databases_are_skipped
WARN[0000] Unknown status type: "status-does-not-exist". Assuming RDS instance "instance-5" is available.
WARN[0000] Unknown status type: "status-does-not-exist". Assuming Aurora cluster "cluster-5" is available.
=== RUN TestWatcher/skip_access_denied_errors
=== RUN TestWatcher/Redshift_labels_matching
=== RUN TestWatcher/Redshift_unavailable_databases_are_skipped
WARN[0000] Unknown status type: "status-does-not-exist". Assuming Redshift cluster "test" is available.
smallinsky
reviewed
Mar 4, 2022
smallinsky
approved these changes
Mar 4, 2022
greedy52
added a commit
that referenced
this pull request
Mar 4, 2022
greedy52
added a commit
that referenced
this pull request
Mar 4, 2022
greedy52
added a commit
that referenced
this pull request
Mar 8, 2022
greedy52
added a commit
that referenced
this pull request
Mar 8, 2022
greedy52
added a commit
that referenced
this pull request
Mar 9, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #10647
Testing