This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Add rolemap support to teleport-plugin-email chart #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbence
requested review from
klizhentas,
russjones,
r0mant,
Joerger,
tcsc and
zmb3
as code owners
2 tasks
kbence
force-pushed
the
bence/teleport-plugin-email-add-rolemap
branch
from
013c307 to
671f22a
Compare
wadells
approved these changes
May 12, 2022
charts/access/email/tests/__snapshot__/configmap_test.yaml.snap
Outdated
Show resolved
Hide resolved
kbence
force-pushed
the
bence/teleport-plugin-email-add-rolemap
branch
2 times, most recently
from
314ce80 to
4082129
Compare
kbence
force-pushed
the
bence/teleport-plugin-email-add-rolemap
branch
from
4082129 to
62d5e83
Compare
Joerger
approved these changes
May 13, 2022
This was referenced May 16, 2022
marcoandredinis
added a commit
that referenced
this pull request
May 18, 2022
This is the output of `make update-version VERSION=9.2.3` There was a missing snapshot version update There was a PR, based on 9.2.1 which added a new snapshot This PR was rebased from master whose version was already 9.2.3 but we didn't upgrade the snapshot This PR re-runs the `update-version` command My only question is how did this PR got merged even though it had a failing step #547 EDIT it was not marked as required
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #459 with the new configuration value added in #488
Testing
Tested with a MailGun sandbox instance using both the legacy (
delivery.recipients) and the new setting, works as expected.Related to #439