This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Helm chart for acces-plugin-email #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbence
changed the title
kbence
force-pushed
the
bence/helm-chart-access-plugin
branch
from
d29e544 to
be7a67f
Compare
kbence
changed the title
kbence
changed the title
kbence
force-pushed
the
bence/helm-chart-access-plugin
branch
from
45162c4 to
8911303
Compare
kbence
requested review from
klizhentas,
russjones,
r0mant,
Joerger and
tcsc
as code owners
Also removed unused ServiceAccount
- Also added some new Makefile targets - Switched for an alpine image for the Drone build
kbence
force-pushed
the
bence/helm-chart-access-plugin
branch
from
7301a30 to
bd0b16d
Compare
wadells
approved these changes
Mar 29, 2022
charts/access/email/Chart.yaml
Outdated
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.1.0 |
There was a problem hiding this comment.
I'd like for this to hit 1.0.0 before we release to customers. It doesn't (and probably shouldn't) be there yet in this PR though.
kbence
force-pushed
the
bence/helm-chart-access-plugin
branch
from
64ecd39 to
2f97af2
Compare
Additionally, commented out chart version to indicate it's not ready yet
Build fails without a valid version in Chart.yaml, so I updated it to 1.0.0 (the chart won't change anyways, only a build will be added)
We might want to consider more detailed tests in the future to avoid this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a Helm chart for
access-plugin-emailand it'll serve as a base for the rest of the plugins.Part of #439
TODO:
values.yamladded by the default templateMake it possible to use secrets and configmaps where it's applicable (but also keep string input where it makes sense)helm unittestvalues.schema.jsonto help validating values.Testing done
I've tested the chart in a local minikube environment, I'll also test it under EKS once the images are available on ECR.
I've also added some unit tests using the third party plugin vbehar/helm3-unittest (we are already using it in gravitational/teleport).
Deployment
Deployment of the helm chart is going to be in a separate pull request.