Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

[7.0.x] Bump Go version to 1.17.5 #2698

Merged
merged 7 commits into from
Jan 19, 2022
Merged

[7.0.x] Bump Go version to 1.17.5 #2698

merged 7 commits into from
Jan 19, 2022

Conversation

bernardjkim
Copy link
Contributor

Description

Bump go version to 1.17.5.

Go 1.14 adds -d=checkptr as a compile-time option for adding instrumentation to check that Go code is following unsafe.Pointer safety rules dynamically. This option is enabled by default (except on Windows) with the -race or -msan flags, and can be disabled with -gcflags=all=-d=checkptr=0.

This lead to failed test cases related to some older dependencies. Disabling the check for now.

Go 1.17 changed how filenames were parsed in multipart forms golang/go#45789. Filename no longer includes directory path in filename. dd03d1e adds a workaround to this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Internal change (not necessarily a bug fix or a new feature)

Linked tickets and other PRs

TODOs

  • Self-review the change
  • Perform manual testing
  • Address review feedback
  • Update upstream references / tags / versions after upstream PR merges (linked above)

Testing

  • Basic manual testing by installing a cluster and joining nodes.

@bernardjkim bernardjkim marked this pull request as ready for review December 29, 2021 18:51
@bernardjkim bernardjkim requested review from a team, wadells and knisbet December 29, 2021 18:51
@bernardjkim bernardjkim merged commit 7e1cd24 into version/7.0.x Jan 19, 2022
@bernardjkim bernardjkim deleted the bernard/7.0.x/go1.17.5 branch January 19, 2022 01:37
bernardjkim added a commit that referenced this pull request Apr 22, 2022
@bernardjkim
Revert "[7.0.x] Bump Go version to 1.17.5 (#2698)"
a4f0ffc 
This reverts commit 7e1cd24.
bernardjkim added a commit that referenced this pull request Apr 25, 2022
@bernardjkim
[7.0.x] Revert go upgrade (#2729)
449ffca 
* Revert "[7.0.x] Bump Go version to 1.17.5 (#2698)"

This reverts commit 7e1cd24.

* Bump planet 7.0.64
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wadells wadells wadells approved these changes

@knisbet knisbet Awaiting requested review from knisbet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bernardjkim @wadells