This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Bump go version to 1.17.5 #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardjkim
force-pushed
the
bernard/master/bump-go
branch
from
2399c0f to
e06d266
Compare
bernardjkim
force-pushed
the
bernard/master/bump-go
branch
from
a35f51f to
303644e
Compare
wadells
approved these changes
Dec 16, 2021
knisbet
approved these changes
Dec 16, 2021
Wouldn't hurt to add unit tests. Added a few test cases in 4e2afbb |
wadells
approved these changes
Dec 16, 2021
bernardjkim
added a commit
that referenced
this pull request
Dec 23, 2021
* Disable check for unsafe.Pointer safety rules * Fix multipart form parsing
5 tasks
bernardjkim
added a commit
that referenced
this pull request
Dec 23, 2021
* Disable check for unsafe.Pointer safety rules * Fix multipart form parsing
5 tasks
bernardjkim
added a commit
that referenced
this pull request
Dec 23, 2021
* Disable check for unsafe.Pointer safety rules * Fix multipart form parsing
5 tasks
bernardjkim
added a commit
that referenced
this pull request
Jan 18, 2022
* Disable check for unsafe.Pointer safety rules * Fix multipart form parsing
bernardjkim
added a commit
that referenced
this pull request
Jan 19, 2022
* Disable check for unsafe.Pointer safety rules * Fix multipart form parsing
bernardjkim
added a commit
that referenced
this pull request
Jan 19, 2022
* Bump go version to 1.17.5 (#2694) * Disable check for unsafe.Pointer safety rules * Fix multipart form parsing * GO111MODULE=off while installing generate * Bump planet to 8.0.10
bernardjkim
added a commit
that referenced
this pull request
Jan 19, 2022
* Bump go version to 1.17.5 (#2694) * Disable check for unsafe.Pointer safety rules * Fix multipart form parsing * GO111MODULE=off while installing generate * GO111MODULE=off with go build * Bump go version for testbox * GO111MODULE=off with go test * Bump planet to 7.0.62
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump go version to
1.17.5.This lead to failed test cases related to some older dependencies. Disabling the check for now.
Go 1.17 changed how filenames were parsed in multipart forms golang/go#45789. Filename no longer includes directory path in filename. dd03d1e adds a workaround to this change.
Type of change
Linked tickets and other PRs
TODOs
Testing