This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Show paypal email on account page #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is how the account page looks for a user with PayPal configured. |
|
One problem I see here is the Payments by Balanced image on top. If we're showing PayPal in this table, then it kind of implies that PayPal payments are by Balanced too. |
|
My 2 cents are: when in doubt, go with what's easier to implement (and maintain). Don't hide the bank account row, and don't implement the removal. The only thing left is to move the "Payments by Balanced" image. |
This is only for people with a paypal email configured.
rohitpaulk
force-pushed
the
add-paypal-to-account-page
branch
from
4eefafd to
22d3a13
Compare
|
Removed the 'payments by' image. |
Changaco
added a commit
that referenced
this pull request
Oct 9, 2014
Show paypal email on account page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to solve #2388.
Do we want to allow people to have both a valid bank account and PayPal configured? If not, the bank account row could be hidden for people with PayPal.
Also, should we let people remove their paypal email themselves? We're unsure about adding on #2387, but nothing was said about removal. In fact, we had a support request recently where a user wanted his PayPal email removed.