Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

First stab at converting to invoke tasks #2295

Merged
merged 5 commits into from
Apr 18, 2014

Conversation

patcon
Copy link
Contributor

@patcon patcon commented Apr 17, 2014

Ref: #2294

@@ -41,3 +41,6 @@

./vendor/vcrpy-0.6.0.tar.gz
./vendor/environment-1.0.0.tar.gz

invoke==0.7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should vendorize until we don't. No?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha I guess I was being sneaky :) I'll bundle the tarball.

And bah. I just realized that scrubbing the tarballs out of the git history later is going to break any flavoured markdown links to commit hashes. I was thinking we'd be able to do that with minimal consequence down the road, but it would be an inconvenience to break those :/

@chadwhitacre
Copy link
Contributor

Is the name of the tasks module an invoke magical name?

@patcon
Copy link
Contributor Author

patcon commented Apr 18, 2014

Yep, tasks is what the file or dir needs to be called, as far as I can tell. You have another preference? tasks is common across rake-like task runners, so non-python folks should recognize it

@patcon
Copy link
Contributor Author

patcon commented Apr 18, 2014

Look ok? Just want to know whether we like invoke. Feel free to merge, and conversion of the rest can be a new PR (might work on bitcoin payout script first)

@patcon
Copy link
Contributor Author

patcon commented Apr 18, 2014

Accompanying docs in other PR

"""
Usage:

[gittip] $ env/bin/invoke set_paypal_email -u username -p [email protected] [-a 12e4s678] [--overwrite]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you're in a virtualenv, env/bin is on your PATH. So you can just call:

[gittip] $ invoke set_paypal_email ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. hm. When I run make env, I don't seem to get an active virtualenv... Am I missing something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to activate the virtualenv yourself, like so:

$ source env/bin/activate

Or you can use bash's . alias for source:

$ . env/bin/activate

I have a shell alias so I can just do:

$ a

chadwhitacre added a commit that referenced this pull request Apr 18, 2014
First stab at converting to invoke tasks
@chadwhitacre chadwhitacre merged commit 41ee162 into master Apr 18, 2014
@chadwhitacre chadwhitacre deleted the convert-scripts-to-invoke branch April 18, 2014 18:31
@chadwhitacre
Copy link
Contributor

Thanks @patcon! :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants