Link venmo #1857
Link venmo #1857
Conversation
Conflicts: gittip/elsewhere/__init__.py
Conflicts: gittip/elsewhere/__init__.py gittip/models/participant.py www/%username/username.json.spt
Conflicts: configure-aspen.py default_local.env default_tests.env gittip/models/_mixin_elsewhere.py gittip/wireup.py www/%username/index.html.spt www/%username/members/index.html.spt www/on/confirm.html.spt www/on/take-over.html.spt
|
All tests pass for me and linking an account works as expected. I'll let someone who was working with Venmo release this one. Thanks for the work guys! |
|
related: #1369. The refactoring in our PR fixes a lot of the same pain points. |
|
@whit537 will review this one. |
| @@ -0,0 +1,3 @@ | |||
| ALTER TABLE elsewhere ADD COLUMN access_token text DEFAULT NULL; | |||
There was a problem hiding this comment.
Let's wrap these in a single BEGIN/END transaction block (see schema.sql for reference).
| return username | ||
|
|
||
|
|
||
| class ProblemChangingUsername(Exception): |
There was a problem hiding this comment.
This duplicates what's in gittip/exceptions.py, no?
There was a problem hiding this comment.
Good catch -- we must have missed that during a merge.
| @@ -1,38 +1,53 @@ | |||
| DATABASE_URL=postgres://gittip:gittip@localhost:5432/gittip | |||
There was a problem hiding this comment.
*.env reorg looks good, thanks. :)
There was a problem hiding this comment.
One thing to note, swaddle now displays 11 warnings in a row about skipping blank lines.
There was a problem hiding this comment.
Ah, we must have missed that because we didn't regenerate our environments. Would running after a make clean show me these warnings?
There was a problem hiding this comment.
Don't sweat it, we're porting away from swaddle (#468).
There was a problem hiding this comment.
Unless @clone1018 wants to sweat it, and add line breaks under #468. :-)
Conflicts: gittip/wireup.py
| @@ -11,6 +12,9 @@ | |||
| from gittip import canonize, configure_payments | |||
| from gittip.security import authentication, csrf, x_frame_options | |||
| from gittip.utils import cache_static, timer | |||
| from gittip.elsewhere import platforms_ordered | |||
There was a problem hiding this comment.
This is unused in this file.
cc @simon-weber
Issue: #1839
This PR adds Venmo as a linkable account (but not an auth-able one). This is the first step towards several possible new features powered by Venmo (using Venmo as a funding source for recurring tips, using Venmo for paying out developers, and possibly using Venmo as a solution for #5).
This PR also does stopgap refactoring of several parts of elsewhere:
platform_classesregistryAccountElsewhereobjects so that convenience methods can be used on existing accounts(sorry about the gross extraneous merge commits, we can rebase this a bit if y'all want)