refactor accounts elsewhere #1369

chadwhitacre · 2013-09-02T20:42:10Z

Currently we have four accounts elsewhere, three useful for authentication (Bitbucket, GitHub, Twitter) and one that can be connected but not used for authentication (Bountysource). These are implemented in a very WET way and we need to DRY it up. This is an old pull request from @lyndsysimon that I brought over from his fork into a branch on the main repo so we can bring more hands on deck.

review OO model
review simplates
review CSRF/security

Bitbucket

Bountysource

connect to existing
reconnect (merge) to existing

GitHub

OpenStreetMap

sign in
connect to existing
reconnect (merge) to existing

Edit by Changaco: the following aren't possible for this plaftorm, see #1369 (comment)

Twitter

Venmo

connect to existing
reconnect (merge) to existing

Tests pass!

Conflicts: configure-aspen.py gittip/models/participant.py gittip/wireup.py

I should've done this on the last commit but neglected to.

Again, should have been done in the merge.

When LyndsySimon started on the accounts elsewhere refactor (#1369) he also started adding support for Google accounts as well. I've made a "google" branch to keep that code around, I'm ripping it out of the elsewhere branch because our first goal needs to be to refactor accounts elsewhere without any user-visible changes.

HTML-escape some things and fix up API for oauth URLs.

chadwhitacre · 2013-10-04T18:05:31Z

IRC

the bitbucket page is missing gravatar
there is no sign-in link on bitbucket
there is no lock button on bitbucket

Actually, these are bugs with the current implementation (IRC). Let's pick them off with this PR if we can.

chadwhitacre · 2013-10-04T18:08:03Z

unknown platform should be 404 (not 500)

We were using "Service" but in the `elsewhere` table we use `platform`.

chadwhitacre · 2013-10-04T20:20:23Z

So it turns out that this branch still contains the /on/{bitbucket,github,twitter}/ directories, meaning that the /on/%platform/ directory is never actually dispatched to. I'm going to start with Twitter and fold that into the refactored version, because Bitbucket and GitHub both have a group/organization concept that make them more complex.

This branch started under an old version of Aspen that didn't require the .spt extension.

This adds a PlatformRegistry to website, which provides access to instances of Platform subclasses, which have a load method that takes a username on the given platform and returns an AccountElsewhere orm.Model. This is all barely working with one test. Surely other tests are broken now, I haven't even checked. Gonna start building back up and out.

chadwhitacre · 2014-02-26T19:26:23Z

I get the following traceback when connecting a Bountysource account:

Traceback (most recent call last):
  File "/Users/whit537/personal/gittip/www.gittip.com/env/lib/python2.7/site-packages/algorithm.py", line 288, in run
    new_state = function(**deps.as_kwargs)
  File "/Users/whit537/personal/gittip/www.gittip.com/env/lib/python2.7/site-packages/aspen/algorithms/website.py", line 88, in get_response_for_resource
    return {'response': resource.respond(request)}
  File "/Users/whit537/personal/gittip/www.gittip.com/env/lib/python2.7/site-packages/aspen/resources/dynamic_resource.py", line 52, in respond
    exec self.pages[1] in context
  File "/Users/whit537/personal/gittip/www.gittip.com/www/on/%platform/associate.spt", line 29, in 
    account = platform.upsert(platform.get_user_self_info(sess))
  File "/Users/whit537/personal/gittip/www.gittip.com/gittip/elsewhere/bountysource.py", line 69, in get_user_self_info
    return self.extract_user_info(info)
  File "/Users/whit537/personal/gittip/www.gittip.com/gittip/elsewhere/__init__.py", line 181, in extract_user_info
    gravatar_id = hashlib.md5(email.strip().lower()).hexdigest()
NameError: global name 'email' is not defined

DEBUG is so generic, it's impossible to know what it's for without a comment.

chadwhitacre · 2014-02-26T20:57:01Z

Per IRC, I'm hitting this problem with Venmo:

pid-78415 thread-4399927296 (CP Server Thread-10) Unable to find key "username" in venmo API response:
pid-78415 thread-4399927296 (CP Server Thread-10) {
pid-78415 thread-4399927296 (CP Server Thread-10)     "data": {
pid-78415 thread-4399927296 (CP Server Thread-10)         "balance": null,
pid-78415 thread-4399927296 (CP Server Thread-10)         "user": {
pid-78415 thread-4399927296 (CP Server Thread-10)             "username": "whit537",
pid-78415 thread-4399927296 (CP Server Thread-10)             "first_name": "Chad",
pid-78415 thread-4399927296 (CP Server Thread-10)             "last_name": "Whitacre",
pid-78415 thread-4399927296 (CP Server Thread-10)             "display_name": "Chad Whitacre",
pid-78415 thread-4399927296 (CP Server Thread-10)             "is_friend": false,
pid-78415 thread-4399927296 (CP Server Thread-10)             "friends_count": 5,
pid-78415 thread-4399927296 (CP Server Thread-10)             "about": " ",
pid-78415 thread-4399927296 (CP Server Thread-10)             "id": "909648748085248861",
pid-78415 thread-4399927296 (CP Server Thread-10)             "phone": null,
pid-78415 thread-4399927296 (CP Server Thread-10)             "profile_picture_url": "https://s3.amazonaws.com/venmo/no-image.gif",
pid-78415 thread-4399927296 (CP Server Thread-10)             "email": null,
pid-78415 thread-4399927296 (CP Server Thread-10)             "date_joined": "2012-06-09T01:49:41"
pid-78415 thread-4399927296 (CP Server Thread-10)         }
pid-78415 thread-4399927296 (CP Server Thread-10)     }
pid-78415 thread-4399927296 (CP Server Thread-10) }

That's after I switched to using access_profile scope to get around this problem:

venmo api responded with 403:
{"error": {"message": "Invalid Scope.", "code": 246}}
venmo lookup failed with 403

chadwhitacre · 2014-02-26T21:06:06Z

Traceback (most recent call last):
  File "/Users/whit537/personal/gittip/www.gittip.com/env/lib/python2.7/site-packages/algorithm.py", line 288, in run
    new_state = function(**deps.as_kwargs)
  File "/Users/whit537/personal/gittip/www.gittip.com/env/lib/python2.7/site-packages/aspen/algorithms/website.py", line 88, in get_response_for_resource
    return {'response': resource.respond(request)}
  File "/Users/whit537/personal/gittip/www.gittip.com/env/lib/python2.7/site-packages/aspen/resources/dynamic_resource.py", line 52, in respond
    exec self.pages[1] in context
  File "/Users/whit537/personal/gittip/www.gittip.com/www/on/%platform/associate.spt", line 29, in 
    account = platform.upsert(platform.get_user_self_info(sess))
  File "/Users/whit537/personal/gittip/www.gittip.com/gittip/elsewhere/__init__.py", line 255, in get_user_self_info
    return self.extract_user_info(self.api_parser(r))
  File "/Users/whit537/personal/gittip/www.gittip.com/gittip/elsewhere/__init__.py", line 169, in extract_user_info
    r.user_name = self.x_user_name(info)
  File "/Users/whit537/personal/gittip/www.gittip.com/gittip/elsewhere/_extractors.py", line 14, in f
    v = info.pop(k, *default)
KeyError: u'username'

pid-78686 thread-4383150080 (CP Server Thread-10) Unable to find key "username" in venmo API response:
pid-78686 thread-4383150080 (CP Server Thread-10) {
pid-78686 thread-4383150080 (CP Server Thread-10)     "balance": null,
pid-78686 thread-4383150080 (CP Server Thread-10)     "user": {
pid-78686 thread-4383150080 (CP Server Thread-10)         "username": "whit537",
pid-78686 thread-4383150080 (CP Server Thread-10)         "first_name": "Chad",
pid-78686 thread-4383150080 (CP Server Thread-10)         "last_name": "Whitacre", 
pid-78686 thread-4383150080 (CP Server Thread-10)         "display_name": "Chad Whitacre", 
pid-78686 thread-4383150080 (CP Server Thread-10)         "is_friend": false, 
pid-78686 thread-4383150080 (CP Server Thread-10)         "friends_count": 5, 
pid-78686 thread-4383150080 (CP Server Thread-10)         "about": " ", 
pid-78686 thread-4383150080 (CP Server Thread-10)         "id": "909648748085248861", 
pid-78686 thread-4383150080 (CP Server Thread-10)         "phone": null, 
pid-78686 thread-4383150080 (CP Server Thread-10)         "profile_picture_url": "https://s3.amazonaws.com/venmo/no-image.gif", 
pid-78686 thread-4383150080 (CP Server Thread-10)         "email": null, 
pid-78686 thread-4383150080 (CP Server Thread-10)         "date_joined": "2012-06-09T01:49:41"
pid-78686 thread-4383150080 (CP Server Thread-10)     }
pid-78686 thread-4383150080 (CP Server Thread-10) }

Not pretty but does the trick. IRC: https://botbot.me/freenode/gittip/msg/11471291/

We're using postgres-2.1.2 in requirements.txt and on master.

chadwhitacre · 2014-02-26T21:53:25Z

www/sign-out.html.spt

@@ -26,7 +26,7 @@ if POST:
        <h1>Are you sure you wish to sign out?</h1>
        <form id="sign-out" method="POST">
            <input name="back_to" type="hidden" value="/" />
-            <input name="csrf_token" type="hidden" value="{{ cookie['csrf_token'].value }}" />
+            <input name="csrf_token" type="hidden" value="{{ csrf_token }}" />


@Changaco Why did we change where csrf_token is taken from?

@whit537 Because: why not ? It's shorter, and now we always get it the same way.

You're right, I flip-flopped the diff in my mind. Thought we were pulling from cookie instead of the other way around.

refactor accounts elsewhere

Squish another #1369 regression

The need for this import entered with #1369.

lyndsysimon added 2 commits June 26, 2013 14:10

Participant pages work for Google users.

6270daa

Tests pass!

WIP - Abstracting into a more generic architecture

783b56d

chadwhitacre mentioned this pull request Sep 2, 2013

integrate with Mozilla Persona #756

Closed

This was referenced Sep 23, 2013

Request for /on/github/github takes over 8s #1491

Closed

add free[-as-in-speech] login option #1503

Closed

chadwhitacre mentioned this pull request Sep 30, 2013

Deal with errors returned by twitter #1525

Closed

This was referenced Sep 30, 2013

Encoding is busted in BountySource linking URL #1020

Closed

Handle requests for strange twitter usernames #1527

Closed

chadwhitacre added 12 commits October 1, 2013 10:55

Merge branch 'master' into elsewhere

5e878ca

Conflicts: configure-aspen.py gittip/models/participant.py gittip/wireup.py

Post-merge get_accounts_elsewhere

2b0a7c0

I should've done this on the last commit but neglected to.

Clean up wireup as well

657cca2

Again, should have been done in the merge.

Move Google config out into wireup

3393dd9

Get old accounts elsewhere barely working TTW

f2e93e0

Modernize a db API call

642ae09

Trim up some imports on elsewhere page

ffd7c13

Clean up elsewhere page some more

6356e13

HTML-escape some things and fix up API for oauth URLs.

Merge branch 'master' into elsewhere

5ad02a9

Here's a failing test for an Aspen upgrade issue

237d40c

Fix an Aspen upgrade issue (UnicodeWithParams)

5190ee7

chadwhitacre added 2 commits October 4, 2013 15:54

Merge branch 'master' into elsewhere

efffad9

Standardize nomenclature on "platform"

6760eae

We were using "Service" but in the `elsewhere` table we use `platform`.

chadwhitacre added 5 commits October 4, 2013 16:25

Add a little whitespace

86c1f5a

Add .spt extension to a couple files

808a7cc

This branch started under an old version of Aspen that didn't require the .spt extension.

Eager-load participant when querying elsewhere

1ec5522

Fix the test for eager-loading participant

d1748ba

chadwhitacre added 2 commits February 26, 2014 14:27

Obey pyflakes

f23bab6

Add comment about DEBUG=1 flag

ff83659

DEBUG is so generic, it's impossible to know what it's for without a comment.

fix venmo's default scope and user info extraction

6c0db7b

chadwhitacre and others added 3 commits February 26, 2014 16:17

Fix bug in extraction of Venmo user_info; #1369

e80ff73

Not pretty but does the trick. IRC: https://botbot.me/freenode/gittip/msg/11471291/

Not sure how this ended up back in; #1369

54a25af

We're using postgres-2.1.2 in requirements.txt and on master.

fix bug in extraction of Venmo user_info, again

5508641

chadwhitacre reviewed Feb 26, 2014
View reviewed changes

chadwhitacre added a commit that referenced this pull request Feb 26, 2014

Merge pull request #1369 from gittip/elsewhere

7290e0d

refactor accounts elsewhere

chadwhitacre merged commit 7290e0d into master Feb 26, 2014

chadwhitacre deleted the elsewhere branch February 26, 2014 22:15

This was referenced Feb 26, 2014

Twitter asks for authorization even though I've already authorized Gittip #2076

Closed

InsecureTransportError #2077

Closed

Changaco mentioned this pull request Feb 26, 2014

fix elsewhere refactor bugs #2078

Merged

chadwhitacre added a commit that referenced this pull request Feb 26, 2014

Append branch.sql to schema.sql; #1369

ff6052d

chadwhitacre added a commit that referenced this pull request Feb 26, 2014

Squish another #1369 regression

b856e3c

seanlinsley added a commit that referenced this pull request Feb 27, 2014

Merge pull request #2079 from gittip/another-avatar-url

2355620

Squish another #1369 regression

seanlinsley mentioned this pull request Feb 27, 2014

A button for connecting accounts? #2081

Closed

This was referenced Feb 27, 2014

balanced_customer_href is corrupted #2085

Closed

connect Flattr account #104

Closed

chadwhitacre added a commit that referenced this pull request Feb 27, 2014

Fix bug in events page for #2006

d36e6e2

The need for this import entered with #1369.

zbynekwinkler mentioned this pull request Mar 1, 2014

Fix delete elsewhere #2106

Merged

chadwhitacre mentioned this pull request Apr 14, 2014

Clean up db schema #1549

Closed

Changaco mentioned this pull request May 2, 2014

unicode flub in GitHub API usage #1489

Closed

chadwhitacre mentioned this pull request May 24, 2014

unicode in Twitter image URL results in UnicodeDecodeError #890

Closed

chadwhitacre mentioned this pull request Jun 5, 2014

/on/github/mdo/ has two records in elsewhere #1395

Closed

Changaco mentioned this pull request Aug 12, 2014

bitbucket group elsewhere is 500 #2050

Closed

chadwhitacre unassigned Changaco Apr 17, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor accounts elsewhere #1369

refactor accounts elsewhere #1369

chadwhitacre commented Sep 2, 2013

chadwhitacre commented Oct 4, 2013

chadwhitacre commented Oct 4, 2013

chadwhitacre commented Oct 4, 2013

chadwhitacre commented Feb 26, 2014

chadwhitacre commented Feb 26, 2014

chadwhitacre commented Feb 26, 2014

chadwhitacre Feb 26, 2014

Changaco Feb 26, 2014

chadwhitacre Feb 26, 2014

refactor accounts elsewhere #1369

refactor accounts elsewhere #1369

Conversation

chadwhitacre commented Sep 2, 2013

Bitbucket

Bountysource

GitHub

OpenStreetMap

Twitter

Venmo

chadwhitacre commented Oct 4, 2013

chadwhitacre commented Oct 4, 2013

chadwhitacre commented Oct 4, 2013

chadwhitacre commented Feb 26, 2014

chadwhitacre commented Feb 26, 2014

chadwhitacre commented Feb 26, 2014

chadwhitacre Feb 26, 2014

Choose a reason for hiding this comment

Changaco Feb 26, 2014

Choose a reason for hiding this comment

chadwhitacre Feb 26, 2014

Choose a reason for hiding this comment