implement account disconnect

[chadwhitacre]

Should be a simple delete from elsewhere where platform='foo' and participant_id='bar' (simple only because we're not storing events and computing state for this yet. :-( ) ... but we can't delete the last account.

The $150 bounty on this issue has been claimed at Bountysource.

[chadwhitacre]

+1 from @JeffSpies over on #804.

[chadwhitacre]

+1 from @kutf on #823.

[chadwhitacre]

Actually, we want to leave the account in elsewhere, we just want to update the participant column. We also want to log the change.

[chadwhitacre]

Another one:

https://twitter.com/HairyFotr/status/322130184872546304

[chadwhitacre]

+1 from @blakewatters

[chadwhitacre]

+1 from @dansage in private email.

[dansage]

Just verifying the +1 above

[chadwhitacre]

+1 from @icyfenix.

[lizTheDeveloper]

Verified +1!

[chadwhitacre]

+1 from @areski via Twitter.

[chadwhitacre]

P.S. When the user has more than one linked account, I'm dealing with this by running:

delete from elsewhere where participant='foo' and platform='twitter';

[chadwhitacre]

+1 from @cornchz via Twitter.

[chadwhitacre]

+1 from @cmbeelby via Twitter DM.

[coolbreezechloe]

Thanks. Also just noticed when I reconnected to the correct account that Gittip request access to my private repo's (read and write) on bitbucket. Is this necessary? Not sure if you are even using that info.

[chadwhitacre]

@cmbeelby That's a Bitbucket limitation: #822. :-(

[chadwhitacre]

+1 from @ElijahLynn via Twitter.

[ElijahLynn]

Thanks Chad!

[chadwhitacre]

+1 from @jorgeam91 in private email.

[chadwhitacre]

+1 from @dansup in email.

[chadwhitacre]

+1 from @amorgner in email.

[chadwhitacre]

+1 from @add1sun on Twitter.

[chadwhitacre]

+1 from @YesCT on Twitter.

[chris-morgan]

+1 from me; I have two Bitbucket accounts (personal and Uni) and connected the wrong one by accident; now I can't fix that.

[chadwhitacre]

@chris-morgan Try now?

[chris-morgan]

@whit537 Thanks.

[chadwhitacre]

+1 from @jdorfman on Twitter.

[chadwhitacre]

+1 from @sc0ttkclark in IRC.

[chadwhitacre]

+1 from @MarcelGruenauer on Twitter (two).

[sferik]

FYI, my bounty expires in 10 days. Any hope this will be fixed by then?

[chadwhitacre]

@sferik Yes! We have a PR open (#1976). It is backed up behind another long-standing major PR (#1369). My goal is to land #1369 "soon" so we can process #1976 before the bounty expires. @zwn deserves it. :-)

[sferik]

@whit537 Cool. I don’t know if this is possible on Bountysource but I’d be willing to extend the deadline by a few days. Happy to see progress is being made on this year-old issue.

[chadwhitacre]

@sferik Ready for review! :-)

[sferik]

@whit537 It doesn’t seem to work. When I hit the “Disconnect” button, it shows me this dialog box:

Nothing happens if I press the “OK” button.

[zbynekwinkler]

We should probably wait until #2089 gets in. It seems it is finding some problem in disconnecting but cannot report it back 😦

[zbynekwinkler]

Unfortunately all I can say is that it works for me. I have just disconnected my twitter account. We don't keep logs for 400 requests because the error explanation is supposed to go the the user but it will not until we get #2089 where @whit537 and @Changaco are discussing some details. But the error can be only one of LastElsewhere or NonexistingElsewhere (see delete-elsewhere.json.spt). What I am trying to say is that I have no idea what is going on for you @sferik 😟

[seanlinsley]

Added context: I'm able to disconnect Twitter, but not Venmo.

[sferik]

Update: Disconnecting my Twitter, GitHub, Bitbucket, and OpenStreetMap all work successfully but disconnecting my Bountysource and Venmo accounts fails.

[zbynekwinkler]

I see. The merge didn't go well and we have lost the ability to delete nonsigning platforms.
33be817
The original idea was that you should not be able to lock yourself out of your account so I was checking if there is at least one signing account left.

[zbynekwinkler]

I am working on a fix.

[Progi1984]

Ok for me with Twitter ;) Thanks :)

[zbynekwinkler]

@sferik Care to give it another try? The fix has been deployed, I was able to detach my Bountysource account.

[sferik]

Nice job. Bounty approved. Get that money.

[untitaker]

It doesn't seem like this is implemented?

[seanlinsley]

@untitaker it doesn't look like you're logged in. You should see something similar to this:

[untitaker]

I am logged in. It does seem like the button is there, but... somewhere:

I am using Firefox 28.

[untitaker]

Removing position:absolute seems to work, seems the wrapping <td>'s position: relative doesn't have any effect.

[untitaker]

It seems like this is behavior special to <td>s, moving the account-details class to a div works too:

<td>
    <div class="account-details">
    ...
    </div>
</td>

[seanlinsley]

Hmm, yeah that's definitely a problem. @clone1018 and I have confirmed with locally. Writing up a new ticket for this.