Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support actors as first-class entity #41

Closed
behas opened this issue Sep 29, 2022 · 2 comments
Closed

Support actors as first-class entity #41

behas opened this issue Sep 29, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@behas
Copy link
Member

behas commented Sep 29, 2022

Currently, tags carry labels / strings; it should also be possible to link a tag with an actor (e.g., some VASP), which is defined as first-class entity.

@behas behas added the enhancement New feature or request label Sep 29, 2022
@behas behas self-assigned this Sep 29, 2022
@behas behas assigned cybersec-code and unassigned behas Nov 28, 2022
@cybersec-code
Copy link
Contributor

Pull request #66 solves the first step in this task (supporting ActorPacks); we still need to define how to integrate TagPacks with ActorPacks (e.g. replacing some labels with actors)

@mdragaschnig
Copy link
Member

mdragaschnig commented Jan 24, 2023

After discussing the integration of actors with tags:

  • actors are statically defined by tagpack creators; in a dedicated optional "actor" field in the tagpack file
  • the tagpack-tool offers creators of tagpacks some support for finding a suitable actor: e.g. for a given label, or labels in a given tagpack file, a new tagpack command suggest_actors_for_tags checks in the database for suitable actors, and prints the information/suggestions to the console, or writes it to a file, or maybe even creates an updated tagpack accordingly
  • the tagpack creator checks the tagpack for correctness
  • actor information (if present) in tagpacks is inserted into the database along with the other tag infos

@soad003 soad003 self-assigned this Feb 9, 2023
@soad003 soad003 added this to the Release r23.03 - Actor Support milestone Feb 9, 2023
soad003 added a commit that referenced this issue Feb 10, 2023
@mdragaschnig mdragaschnig assigned behas and mdragaschnig and unassigned behas Feb 22, 2023
mdragaschnig added a commit that referenced this issue Feb 23, 2023
Add option to interactively update TagPack files #41
soad003 added a commit that referenced this issue Feb 23, 2023
soad003 added a commit that referenced this issue Feb 28, 2023
…rt, add quality metric cli commands top tags without actor and top actors without jur (#41)
soad003 added a commit that referenced this issue Feb 28, 2023
@soad003 soad003 closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants