Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS: Fix strict issues in src/language #3139

Closed
wants to merge 1 commit into from
Closed

TS: Fix strict issues in src/language #3139

wants to merge 1 commit into from

Conversation

leebyron
Copy link
Contributor

Depends on #3138

  • Add "strict": true to tsconfig.json
  • Fix all issues that arise within src/language

@leebyron leebyron requested review from IvanGoncharov and saihaj May 27, 2021 04:52
@leebyron leebyron mentioned this pull request May 27, 2021
Closed
@leebyron leebyron force-pushed the ts-strict-subscription branch from b12f720 to 4bcd3f2 Compare May 27, 2021 05:32
@leebyron leebyron force-pushed the ts-strict-language branch 3 times, most recently from bd40120 to 3fe5826 Compare May 27, 2021 06:12
@leebyron leebyron force-pushed the ts-strict-subscription branch 2 times, most recently from 62e53c4 to 8824ccc Compare May 27, 2021 06:39
@leebyron leebyron force-pushed the ts-strict-language branch from 3fe5826 to 8d39dd9 Compare May 27, 2021 06:42
@leebyron leebyron force-pushed the ts-strict-subscription branch from 8824ccc to 7db2e4b Compare May 27, 2021 06:54
@leebyron leebyron force-pushed the ts-strict-language branch from 8d39dd9 to f0d7242 Compare May 27, 2021 06:54
@leebyron leebyron force-pushed the ts-strict-subscription branch from 7db2e4b to f41145b Compare May 27, 2021 07:02
@leebyron leebyron force-pushed the ts-strict-language branch from f0d7242 to bf47ef8 Compare May 27, 2021 07:03
@leebyron leebyron mentioned this pull request May 27, 2021
Merged
@leebyron leebyron deleted the ts-strict-language branch May 27, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saihaj saihaj saihaj approved these changes

@IvanGoncharov IvanGoncharov Awaiting requested review from IvanGoncharov

Assignees
No one assigned
Labels
PR: internal 🏠
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leebyron @saihaj