-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS: Enable strict mode #3143
Merged
Merged
TS: Enable strict mode #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
ts-enable-strict
branch
from
May 27, 2021 05:34
839bc0c
to
069f561
Compare
leebyron
force-pushed
the
ts-enable-strict
branch
from
May 27, 2021 06:12
069f561
to
7cd9c31
Compare
leebyron
force-pushed
the
ts-enable-strict
branch
2 times, most recently
from
May 27, 2021 06:14
208394b
to
4b14553
Compare
leebyron
force-pushed
the
ts-strict-error
branch
2 times, most recently
from
May 27, 2021 06:55
c1fe84f
to
b14e9f7
Compare
leebyron
force-pushed
the
ts-enable-strict
branch
from
May 27, 2021 06:55
4b14553
to
8099201
Compare
* Add `"strict": true` to tsconfig.json * Fix all issues that arise within `src/validation`
leebyron
force-pushed
the
ts-enable-strict
branch
from
May 27, 2021 07:04
8099201
to
10bbbbd
Compare
saihaj
approved these changes
May 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Apr 3, 2023
…sion Context: revert back to use bind since it way faster Reverts: graphql@ac70985#diff-abcb97c7918631025353ea7ae5c1913946f00eb9d5d7ea9fe6060b6cfd92d480L761
IvanGoncharov
added a commit
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ts-expect-error
messagesCloses #3135
Closes #3136
Closes #3137
Closes #3138
Closes #3139
Closes #3140
Closes #3141
Closes #3142