Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: Enable strict mode #3143

Merged
merged 9 commits into from
May 27, 2021
Merged

TS: Enable strict mode #3143

merged 9 commits into from
May 27, 2021

Conversation

leebyron
Copy link
Contributor

@leebyron leebyron commented May 27, 2021

  • Add "strict": true to tsconfig.json, removed overriding configs
  • Fix all @ts-expect-error messages

Closes #3135
Closes #3136
Closes #3137
Closes #3138
Closes #3139
Closes #3140
Closes #3141
Closes #3142

@leebyron leebyron requested review from IvanGoncharov and saihaj May 27, 2021 05:28
@leebyron leebyron changed the base branch from main to ts-strict-error May 27, 2021 05:29
@leebyron leebyron changed the title Ts enable strict TS: Enable strict mode May 27, 2021
@leebyron leebyron force-pushed the ts-enable-strict branch from 839bc0c to 069f561 Compare May 27, 2021 05:34
@leebyron leebyron force-pushed the ts-enable-strict branch from 069f561 to 7cd9c31 Compare May 27, 2021 06:12
@leebyron leebyron force-pushed the ts-enable-strict branch 2 times, most recently from 208394b to 4b14553 Compare May 27, 2021 06:14
@leebyron leebyron force-pushed the ts-strict-error branch 2 times, most recently from c1fe84f to b14e9f7 Compare May 27, 2021 06:55
@leebyron leebyron force-pushed the ts-enable-strict branch from 4b14553 to 8099201 Compare May 27, 2021 06:55
@leebyron leebyron force-pushed the ts-enable-strict branch from 8099201 to 10bbbbd Compare May 27, 2021 07:04
Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@leebyron leebyron changed the base branch from ts-strict-error to main May 27, 2021 22:44
@leebyron leebyron merged commit bf26a52 into main May 27, 2021
@leebyron leebyron deleted the ts-enable-strict branch May 27, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants