refactor: Avoid copying Span when evaluating rules #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyranron
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1209 (comment), making
Spanninggeneric overSpallows avoiding copying 6usizes (theSpan) in places where a borrowed Spanning needs to be type mapped. I.e. theDocumentcontainsSpanning<InputValue>, butInputValueis an enum, so when the spanned item's type gets mapped into a reference to each variant, there's no need to transform&Spanning<T, Span>toSpanning<&U, Span>. It can instead be transformed to aSpanning<&U, &Span>.This applies to the
Visitortrait and its methods related to the visitation ofInputValues. TheVisitortrait is public, but#[doc(hidden)].