Spanned arguments #1209
Merged
Spanned arguments #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audunhalland
commented
Nov 9, 2023
| @@ -52,15 +52,15 @@ impl Span { | |||
|
|
|||
| /// Data structure used to wrap items into a [`Span`]. | |||
| #[derive(Clone, Copy, Debug, Eq, Hash, PartialEq)] | |||
| pub struct Spanning<T> { | |||
| pub struct Spanning<T, Sp = Span> { | |||
There was a problem hiding this comment.
The added generic argument probably influences how this is documented, but not sure.
The point of the generic is to avoid making a separate type like BorrowedSpanning, but I'm up for improvement suggestions.
The ability to borrow a Span can lead to slightly more performant code in various places. Currently only in look_ahead, other future suggestions are e.g. the input validation rules.
tyranron
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #1206
This change improves diagnostics when performing manual/domain-specific post-validation of arguments using LookAheadArguments. In the case of an error, the produced error message may be able to refer to the exact position in the problematic GraphQL arguments.
On an unrelated note, I noticed
LookAheadArgumentdoes a deep/greedy transform of theInputValueto perform variable substitution. A potential improvement to this is to only do this lazily for each expansion step, i.e. the LookAheadArgument privately keeps a reference to itsInputValueand the variable table and somehow exposes a LookAhead interface on top of this.