Test fixes to use correct ResolveTypeFn and add types to Schema #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, sorry, I hadn't realized that the code in |
|
Should be fixed now; seems to be passing the checks. |
|
Bump. Can we get this merged? Tests are currently failng for my PR on handler because of this bug. |
|
@sogko or @chris-ramon any chance you get this merged? …my PR (graphql-go/handler#14) is also failing due to this issue… |
|
Bump again. I ran into this as well. Fix LGTM |
This was referenced Oct 28, 2016
|
Bump |
|
Can we get this merged? |
|
Any blockers to get this out? |
|
thanks a lot guys! 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for tests, so they cooperate with the current version of graphql. See issue #26.