Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests use old format for ResolveTypeFn #26

Closed
object88 opened this issue Jul 6, 2016 · 1 comment
Closed

Tests use old format for ResolveTypeFn #26

object88 opened this issue Jul 6, 2016 · 1 comment

Comments

@object88
Copy link
Contributor

object88 commented Jul 6, 2016 •
edited
Loading

I'm raising this mostly because I started poking at graphql-go/relay, /graphql, and the starter kit, and got a little confused. In node_test.go and node_global_test.go, the calls to NewNodeDefinition take the wrong prototype for the TypeResolve parameter. Fixing this so simple, even I was able to figure it out!

My questions, then, ...

  • Do you accept PRs directly to this repo? ... and if so, do you have a pattern to follow for branch names? Otherwise, I presume the best practice is to fork and issue a PR from there?
  • Will you accept a PR even if all tests are not passing? I haven't dug in enough to see what else is going on, but while they now compile, there are failures. Nevermind; figured out how to fix the tests.
@object88 object88 mentioned this issue Jul 7, 2016
Merged
@object88
Copy link
Contributor Author

object88 commented Dec 9, 2017

PR merged; closing issue. Thanks, everyone!

@object88 object88 closed this as completed Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@object88