Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added contribution guidelines (CONTRIBUTING.md) #33

Merged
merged 8 commits into from
Mar 2, 2016

Conversation

sogko
Copy link
Member

@sogko sogko commented Oct 29, 2015

Based on discussions on #29 , added a initial draft of contribution guidelines.

It is based on io.js' and gobot.io's guidelines, which has a good write up on setting up a local copy of your fork while still maintaining import paths.

View it here: https://github.com/sogko/graphql-go/blob/fork/master/CONTRIBUTING.md

Notes:

  • I omitted out few items from gobot's guidelines. I thought I'd run it by everyone first before adding it to the guideline.
    • about having separate dev branch for ongoing development and master branch for hot fixes.
    • about using git's signing-off feature
    • about mandating all PRs to use "fast-forward" merge.

Discussions are welcome! Help to shape the community 👍🏻

sogko added 8 commits October 29, 2015 01:50
Merge latest changes from HEAD
Merge latest changes from HEAD
Based of io.js and gobot.io guidelines.
Updated instructions to set up local copy of your fork as a remote
Fixed indentation for Landing PRs section
@pyrossh
Copy link
Contributor

pyrossh commented Nov 3, 2015

Hi @sogko,

I think the contribution guidelines are good and we also need to add a section for it on the Readme. For the dev and master branch it seems good and what about releases?

sogko added a commit that referenced this pull request Mar 2, 2016
Added contribution guidelines (CONTRIBUTING.md)
@sogko sogko merged commit ac8b40b into graphql-go:master Mar 2, 2016
@sogko
Copy link
Member Author

sogko commented Mar 2, 2016

I'll go ahead and merge this to move this along, further enhancements and improvements can be discussed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants