-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rally community... #29
Comments
Yeah... We started using it too.. some contributor guidelines will help and maybe some Todos and features complete w.r.t. graphql-js would be good |
+1 |
Thanks @EmergentBehavior for bringing this up 👍🏻 You are right that this area is lacking and requires more attention. (Previously I relied on the TODO list on the README to see how I can contribute but I noticed it's out-of-date currently.) I can help out with sharing the latest nearest-of-the-nearest-term goals that we definitely need to address
Other longer-term goals
As to the parity of this project vs But I doubt it'll be a 1-1 port with Cheers! |
@sogko For information on unimplemented features as of yet (such as the Validator) is the single source of truth just the spec for GraphQL or do you already have plans you'd like to see done specifically for those features? I'd love to help contribute and just want to make sure that I don't do a lot of work on something in a way different from the plans of this library moving forward. Also, I know you do a lot of work with this library outside of just this, such as your graphql-go-handler and your Relay specific wrapper for this library. Which are all great things. One thing I found lacking was specifically related to this library (as addressed in the 'Documenation' issue) is to have more examples specifically focusing on basic usage of just this library. I spent some time with graphql-js after finding graphql-go to define the things I was looking to define before finally coming back here and having the ability to transfer that knowledge into how to do those similar things in Go. Which is great that this could be done, but any examples that get written (including yours), I think would be extremely beneficial if they only used this library to handle the GraphQL pieces. Even if you define it all raw with GraphQL as is and then refactor it using your Relay wrapper for example so at least the understanding of this library is talked about and discussed. I'm bringing this up not just because of my desire to have seen that but a recent conversation in Gitter (for this repo). I'm referring to this comment from thanhliem89dn specifically (and I share his sentiment, this was my desire as well):
All of these utilities are great to have, but I think a full understanding of this library offers is a better place to start before introducing the other ones. I got off topic and rambled. I'm sorry. |
@sogko Thanks for the update. Am going to submit another PR to update the |
@EmergentBehavior that's excellent 👍🏻! Thanks! |
@bbuck Thanks for the input, appreciate very much 👍🏻 Yes you are right, documentation is really lacking right now, in this project and others in its ecosystem currently. I think once we nail down the package naming, I'll help and do my part in providing better documentation. I wrote the I have yet to put down my motivations on why I wrote those, but to draw parallels with the GraphQL in JS:
Some of the other projects that I contributed do use Another project that I wrote used only
I did wrote a couple of posts on Golang + GraphQL + Relay but again, those are heading into the direction of Relay-specific details. I do see what you mean there about diving deeper into examples pure GraphQL using
Thanks again! Cheers! |
Based of io.js and gobot.io guidelines.
Most of the vital info seems to be shared in these issues I'm gonna be putting them in the Readme |
@chris-ramon @sogko Not critically important, but now that the package and its sister packages are collected under If someone else has actual design chops feel free to update/iterate :) |
The gopher strikes again haha! Thanks @EmergentBehavior for kicking this off! For inspirations from other implementations:
|
graphql-ruby and graphene ones are great. i can help with a front-end website later too once package is a little more stable. Ruby and Python have more elegant base logos though so it's easier to iterate :) |
Based of io.js and gobot.io guidelines.
EDIT: I see the contributing guidelines. Still, the ref spec is april 2016 And just a thought for the logo - The python logo looks almost like a G, make it a G. and add an o afterwards. |
Keep the dream alive cc: @logie17 |
Thanks a lot guys 🌟 for taking the time to bring interesting ideas, since #32 was merged; let's close this one issue; and continue the conversation on: |
Browsing around it looks like the go-graphql landscape is still in its infancy, however
graphql-go
seems to be one of the more referenced libs out there. I'm looking at using it in my own work and would potentially be happy to start contributing, but it would be helpful to sketch out some a bit more detailed roadmap and near-term goals so potential contributors can see what to focus on.The text was updated successfully, but these errors were encountered: