-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port the rest of the types
package tests
#12
Conversation
Merge latest changes from HEAD
Merge latest changes from HEAD
Merge latest changes from HEAD
…a struct. Try to match the given field name with the struct field name first, before matching with json tag
…utomatically resolve its fields - Implement resolve functions to some introspection field configs. - The rest will be filled in when the tests are ported
- Ported from `type/__tests__/enumType.js` - Some tests are marked as skipped, pending `validator` implementation - Change `GraphQLEnumValueConfigMap` to `map[string]*GraphQLEnumValueConfig`. Consistent with `GraphQLFieldConfigMap` and others
- Ported from `type/__tests__/validation.js` - Some tests are marked as skipped, pending `validator` implementation - Exposed `GetError() error` to GraphQLType interface so that errors can be detected during construction of schema - This was an alternative to throwing a panic.
- Ported from `type/__tests__/definition.js`
- Add guards to checking for nil before reflecting
- Ported from `type/__tests__/introspection.js`
Merge latest changes from HEAD
Merge latest changes from HEAD
Completed porting tests for Notes
/cc @chris-ramon |
- `react-relay` throws an error if `errors` key exist but nil - Checked `express-graphql` implementation, same behaviour (omit if empty)
Port the rest of the `types` package tests
Thanks a lot! for ur work on this one 🌟 finally landed 😄 |
Haha no problem, was glad to contribute 👍🏻 By the way, I've got a live demo of Cheers! |
That is so awesome! 👍 great example! 🚀 , def will take a look closely. |
Merge latest changes from HEAD
Details
Currently the types branch includes some fixes to bugs where introspection does not return the right output when queried (Some of the fixes I've yet to commit to the branch yet).
This PR would not be ready for merge until all tests in the task lists are completed and all tests have passed.
Task list
Test