Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AST constructors parametrized #307

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Make AST constructors parametrized #307

merged 3 commits into from
Apr 20, 2023

Conversation

sungam3r
Copy link
Member

fixes #302

@sungam3r sungam3r self-assigned this Apr 20, 2023
@sungam3r sungam3r requested a review from Shane32 April 20, 2023 13:28
@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Apr 20, 2023
@sungam3r sungam3r changed the title Make AST constructors parametrixed Make AST constructors parametrized Apr 20, 2023
@sungam3r
Copy link
Member Author

This is the last PR of 3 I would like to merge to publish v9.

@sungam3r sungam3r added BREAKING Breaking changes in either public API or runtime behavior and removed test Pull request that adds new or changes existing tests labels Apr 20, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #307 (ebc7aea) into master (568ed79) will decrease coverage by 3.75%.
The diff coverage is 54.04%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
- Coverage   99.77%   96.02%   -3.75%     
==========================================
  Files          85       85              
  Lines        4471     4835     +364     
  Branches      448      448              
==========================================
+ Hits         4461     4643     +182     
- Misses          8      190     +182     
  Partials        2        2              
Impacted Files Coverage Δ
...rser/AST/Definitions/GraphQLArgumentsDefinition.cs 80.00% <50.00%> (-20.00%) ⬇️
...arser/AST/Definitions/GraphQLEnumTypeDefinition.cs 82.35% <50.00%> (-17.65%) ⬇️
...ser/AST/Definitions/GraphQLEnumValuesDefinition.cs 80.00% <50.00%> (-20.00%) ⬇️
...LParser/AST/Definitions/GraphQLFieldsDefinition.cs 80.00% <50.00%> (-20.00%) ⬇️
...er/AST/Definitions/GraphQLInputFieldsDefinition.cs 80.00% <50.00%> (-20.00%) ⬇️
...ST/Definitions/GraphQLInputObjectTypeDefinition.cs 82.35% <50.00%> (-17.65%) ⬇️
.../AST/Definitions/GraphQLInterfaceTypeDefinition.cs 83.33% <50.00%> (-16.67%) ⬇️
...ser/AST/Definitions/GraphQLObjectTypeDefinition.cs 83.33% <50.00%> (-16.67%) ⬇️
...rser/AST/Definitions/GraphQLOperationDefinition.cs 83.33% <50.00%> (-16.67%) ⬇️
...ser/AST/Definitions/GraphQLScalarTypeDefinition.cs 81.25% <50.00%> (-18.75%) ⬇️
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Shane32
Copy link
Member

Shane32 commented Apr 20, 2023

Looks great!

@sungam3r sungam3r merged commit 8483d95 into master Apr 20, 2023
@sungam3r sungam3r deleted the ctors branch April 20, 2023 15:02
Shane32 pushed a commit that referenced this pull request Jun 24, 2023
Shane32 added a commit that referenced this pull request Jun 25, 2023
Shane32 added a commit that referenced this pull request Oct 16, 2023
Shane32 added a commit that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING Breaking changes in either public API or runtime behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise AST constructors
3 participants