Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise AST constructors #302

Closed
sungam3r opened this issue Apr 18, 2023 · 0 comments · Fixed by #307
Closed

Revise AST constructors #302

sungam3r opened this issue Apr 18, 2023 · 0 comments · Fixed by #307

Comments

@sungam3r
Copy link
Member 

          Internally we can still do it the other way.  But the `public` constructor would have proper NRT attributes.  We can also allow for users to pass in `null!` if they like to the constructor, but they are then knowingly breaking NRT semantics.

Originally posted by @Shane32 in #300 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make AST constructors parametrized graphql-dotnet/parser
1 participant
@sungam3r