-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.1.x] set package long description (#2407) | fix dashboard graph metric list icon paths with URL_PREFIX (#2424) | docs: for sql db migration to 1.1 recommend --fake-initial (#2425) | add tag formatting docs (#2426) | Update tags.rst (#242 #2503
Merged
deniszh
merged 49 commits into
graphite-project:1.1.x
from
deniszh:backport/1.1.x/pr-2407_pr-2424_pr-2425_pr-2426_pr-2426_pr-2426_pr-2431_pr-2433_pr-2436_pr-2436_pr-2443_commit-91ed1c0b_pr-2450_pr-2450_pr-2451_pr-2452_pr-2452_pr-2462_pr-2462_pr-2463_pr-2464_pr-2464_pr-2466_pr-2467_
Oct 23, 2019
Merged
[1.1.x] set package long description (#2407) | fix dashboard graph metric list icon paths with URL_PREFIX (#2424) | docs: for sql db migration to 1.1 recommend --fake-initial (#2425) | add tag formatting docs (#2426) | Update tags.rst (#242 #2503
deniszh
merged 49 commits into
graphite-project:1.1.x
from
deniszh:backport/1.1.x/pr-2407_pr-2424_pr-2425_pr-2426_pr-2426_pr-2426_pr-2431_pr-2433_pr-2436_pr-2436_pr-2443_commit-91ed1c0b_pr-2450_pr-2450_pr-2451_pr-2452_pr-2452_pr-2462_pr-2462_pr-2463_pr-2464_pr-2464_pr-2466_pr-2467_
Oct 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use global *_ICON vars like the other image assets
... and --run-syncdb should no longer be needed. Initial migrations were created for all models just before 1.1.0 in d1912d4. Prior to that, some models did not have any migrations (and no initial migration), so --run-syncdb was needed to create tables for them. But now that they have initial migrations, those migrations run because django knows they have never been applied, and they fail because the tables already exist. The --fake-initial option is designed for this situation: it considers initial migrations already done if the tables already exist.
This never worked right, but the backend dealt with it until recent changes. This only happens when the dashboard template is loaded directly from the URL
Using slightly modified functions util.parseDestination(s) from Carbon project.
django.core.exceptions.ImproperlyConfigured: SQLite 3.8.3 or later is required (found 3.8.2).
Change BufferedHTTPReader from extending IOBase to FileIO Move parse_qs from cgi to six.moves
add: adds a constant to a list of series, easier than sumSeries(serie, constantLine(5)) and add a constant to a list of series without summing them. exp: datapoint to the power of e logit and sigmoid: logistic functions Sort transform functions alphabetically in the composer pulldown.
…missing default params, better error messages
I've encountered issues with current code snippet on some instances of centos, which can is fixed by adding extra spaces before \ signs.
Issue #2355 suggests that minimumBelow() works on <= rather than <, to avoid confusion I have updated docstring
This should fix the validation not being aware of legal aliases. fix #2494
{}.keys() is a dict_keys type which it doesn't know how to add but casting with list() seems to work in both versions
Codecov Report
@@ Coverage Diff @@
## 1.1.x #2503 +/- ##
==========================================
- Coverage 79.79% 79.66% -0.14%
==========================================
Files 85 85
Lines 8910 9091 +181
Branches 1906 1948 +42
==========================================
+ Hits 7110 7242 +132
- Misses 1537 1573 +36
- Partials 263 276 +13
Continue to review full report at Codecov.
|
DanCech
approved these changes
Oct 23, 2019
deniszh
deleted the
backport/1.1.x/pr-2407_pr-2424_pr-2425_pr-2426_pr-2426_pr-2426_pr-2431_pr-2433_pr-2436_pr-2436_pr-2443_commit-91ed1c0b_pr-2450_pr-2450_pr-2451_pr-2452_pr-2452_pr-2462_pr-2462_pr-2463_pr-2464_pr-2464_pr-2466_pr-2467_
branch
October 23, 2019 17:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 1.1.x: