-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tag formatting docs #2426
add tag formatting docs #2426
Conversation
d0b229c
to
314b894
Compare
314b894
to
51b918f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2426 +/- ##
==========================================
- Coverage 80.11% 80.05% -0.06%
==========================================
Files 85 85
Lines 8910 8926 +16
Branches 1906 1912 +6
==========================================
+ Hits 7138 7146 +8
- Misses 1504 1508 +4
- Partials 268 272 +4
Continue to review full report at Codecov.
|
d2f1579
to
519ef27
Compare
Added a basic validator:
|
519ef27
to
7149908
Compare
Just some more testing, by actually running graphite and calling the API:
|
LGTM. Should I merge it, @DanCech ? |
…pr-2425_pr-2426_pr-2426_pr-2426_pr-2431_pr-2433_pr-2436_pr-2436_pr-2443_commit-91ed1c0b_pr-2450_pr-2450_pr-2451_pr-2452_pr-2452_pr-2462_pr-2462_pr-2463_pr-2464_pr-2464_pr-2466_pr-2467_ [1.1.x] set package long description (#2407) | fix dashboard graph metric list icon paths with URL_PREFIX (#2424) | docs: for sql db migration to 1.1 recommend --fake-initial (#2425) | add tag formatting docs (#2426) | Update tags.rst (#242
Defining which characters are allowed, and how to query for values containing quotes.
If you agree with the rules defined in this change, then I can also add an according validator to the TagDB