feat(compiler): Support pattern matching "or" patterns #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peblair
reviewed
Mar 22, 2022
|
Does this need formatter support @ospencer |
jozanza
approved these changes
Apr 8, 2022
phated
requested changes
Apr 11, 2022
ospencer
force-pushed
the
oscar/or-patterns
branch
from
808d9ce
to
7765b9b
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the match compiler to properly support or-patterns. The two major changes are how bindings work and how constant patterns are compiled. Slots for each of the bindings needed in each of the branches are created, and during the branch selection process these slots are filled with the proper values. Constant patterns are now compiled the same way constructors are and should be more efficient now.
This opens the door for a number of optimizations we can write, but I left them out of this PR to keep it relatively simple.
You may notice that a fair number of snapshots are a bit bigger now; we need a few optimizations to remove the cruft, which will come after this PR.
Closes #264