Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up regular expression code with or-patterns #696

Closed
peblair opened this issue Jun 4, 2021 · 1 comment · Fixed by #1859
Closed

Clean up regular expression code with or-patterns #696

peblair opened this issue Jun 4, 2021 · 1 comment · Fixed by #1859
Labels
cleanup good first issue stdlib

Comments

@peblair
Copy link
Member

peblair commented Jun 4, 2021

The match expressions in regex.gr contain a variety of duplicated branches which differ only by the variant being matched. We should clean these up using or-patterns.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good first issue stdlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(stdlib): Use | patterns to cleanup pattern matches spotandjake/grain
2 participants
@peblair @ospencer