Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recursive export #475

Merged
merged 3 commits into from
Jan 9, 2021
Merged

fix: recursive export #475

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c15952a
fix: recursive export
Duologic Jan 9, 2021
8d4c49b
Revert "fix: recursive export"
Duologic Jan 9, 2021
c1b221c
fix: set outCh length
Duologic Jan 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/tanka/parallel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ type parallelOpts struct {
// parallelLoadEnvironments evaluates multiple environments in parallel
func parallelLoadEnvironments(paths []string, opts parallelOpts) ([]*v1alpha1.Environment, error) {
jobsCh := make(chan parallelJob)
outCh := make(chan parallelOut)
Comment on lines 21 to -22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For public reference:

A simpler fix to the problem would be to use buffered channels. See https://gobyexample.com/worker-pools for an example

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look.

outCh := make(chan parallelOut, len(paths))

if opts.Parallelism <= 0 {
opts.Parallelism = defaultParallelism
Expand Down