fix: recursive export #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duologic
commented
Jan 9, 2021
sh0rez
reviewed
Jan 9, 2021
Comment on lines
23
to
-22
| jobsCh := make(chan parallelJob) | ||
| outCh := make(chan parallelOut) |
There was a problem hiding this comment.
For public reference:
A simpler fix to the problem would be to use buffered channels. See https://gobyexample.com/worker-pools for an example
captncraig
approved these changes
Jan 9, 2021
This reverts commit c15952a.
sh0rez
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts changes made in #473.
Turns out the workers kept waiting for
outChto be read, this only happens after all 'jobs' have been launched. But asthe limited number of workers kept waiting, no new jobs could be launched.
One of the concerns in #6611 was that a pointer was passed back, this is not the case anymore. The env is now copied
instead of passing along a pointer.