Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k210] fix: add logging to empty bloom #13505

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

grafanabot
Copy link
Collaborator

Backport c263a68 from #13502


What this PR does / why we need it:
Follow up for #13500 to log the empty blooms with their block and offset.

I also moved the bloom empty check outside the reqs loop.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grafanabot grafanabot requested a review from a team as a code owner July 12, 2024 08:20
@grafanabot grafanabot added backport size/S type/bug Somehing is not working as expected labels Jul 12, 2024
@grafanabot grafanabot requested a review from salvacorts July 12, 2024 08:20
@salvacorts salvacorts merged commit 0a5cf35 into k210 Jul 12, 2024
63 checks passed
@salvacorts salvacorts deleted the backport-13502-to-k210 branch July 12, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/S type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants