fix: add logging to empty bloom #13502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
reviewed
Jul 12, 2024
pkg/storage/bloom/v1/fuse.go
Outdated
| // In the case we don't have any data in the bloom, don't filter any chunks. | ||
| if bloom.ScalableBloomFilter.Count() == 0 { | ||
| level.Warn(fq.logger).Log( | ||
| "Found bloom with no data", |
There was a problem hiding this comment.
Suggested change
| "Found bloom with no data", | |
| "msg", "found bloom with no data", |
chaudum
approved these changes
Jul 12, 2024
grafanabot
pushed a commit
that referenced
this pull request
Jul 12, 2024
(cherry picked from commit c263a68)
7 tasks
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow up for #13500 to log the empty blooms with their block and offset.
I also moved the bloom empty check outside the reqs loop.
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR