Drop the deprecated convert command #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
force-pushed
the
remove-convert-cmd
branch
from
30efe9a to
1870bb1
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3365 +/- ##
==========================================
+ Coverage 72.95% 73.05% +0.09%
==========================================
Files 261 256 -5
Lines 20018 19642 -376
==========================================
- Hits 14605 14349 -256
+ Misses 4486 4406 -80
+ Partials 927 887 -40
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
codebien
requested review from
a team,
oleiade and
olegbespalov
and removed request for
a team
oleiade
approved these changes
Oct 4, 2023
olegbespalov
approved these changes
Oct 4, 2023
olegbespalov
added
the
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It drops the har converter as we decided in #1124, and it is following the deprecation process started by #2714.
https://github.com/grafana/har-to-k6 is the alternative