Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a warning when using k6 convert to point to new har-to-k6converter #1124

Closed
markjmeier opened this issue Aug 26, 2019 · 3 comments · Fixed by #1228 or #2714
Closed

Emit a warning when using k6 convert to point to new har-to-k6converter #1124

markjmeier opened this issue Aug 26, 2019 · 3 comments · Fixed by #1228 or #2714
Assignees
Labels
Milestone

Comments

@markjmeier
Copy link

As the title says,k6 convert should emit a warning to point users to the new har-to-k6 tool

@na-- na-- added evaluation needed proposal needs to be validated or tested before fully implementing it in k6 ux labels Aug 26, 2019
@ppcano
Copy link
Contributor

ppcano commented Aug 29, 2019

If the har-to-k6 tool will be the recommended tool, the docs https://docs.k6.io/docs/session-recording-har-support should also be updated.

@cuonglm cuonglm self-assigned this Nov 6, 2019
@cuonglm cuonglm removed the evaluation needed proposal needs to be validated or tested before fully implementing it in k6 label Nov 6, 2019
@cuonglm cuonglm added this to the v0.26.0 milestone Nov 6, 2019
cuonglm added a commit that referenced this issue Nov 6, 2019
cuonglm added a commit that referenced this issue Nov 6, 2019
cuonglm added a commit that referenced this issue Nov 6, 2019
cuonglm added a commit that referenced this issue Nov 11, 2019
@mstoykov mstoykov reopened this Oct 3, 2022
@mstoykov
Copy link
Contributor

mstoykov commented Oct 3, 2022

I reopen this as it was long time ago reverted with #1268

@mstoykov
Copy link
Contributor

mstoykov commented Oct 3, 2022

I am of the opinion that the rational back then was that the lacking functionality was somehow particularly useful and we can't remove it without it.

Given that at least some of the features are still not implemented 2 years+ later - they likely won't be.

I would also argue that given that we haven't fixed anything around the har converter all this time -and haven't gotten any more reports - it is either not used or is perfect. The later seems unlikely.

I would propose that we:

  1. Mark is a deprecated (this issue).
  2. Wait for few releases - we can do as many as we want but I would argue more then 2 less than 6. So let's say the maximum 5 releases.
    3.1 If there is feedback that this is used and is needed and har-to-k6 does not work well enough for this uses case. We would have good arguments for the changes in har-to-k6.
    3.2. If there isn't any feedback - it is very likely this just isn't used. In which case after those releases we drop in the next one.
  3. We can always make k6 convert into its own tool that has the same code but isn't part of k6 if it turns out there is interest.

@mstoykov mstoykov removed this from the v0.26.0 milestone Oct 3, 2022
@na-- na-- added this to the v0.41.0 milestone Oct 5, 2022
@mstoykov mstoykov self-assigned this Oct 5, 2022
mstoykov added a commit that referenced this issue Oct 5, 2022
mstoykov added a commit that referenced this issue Oct 6, 2022
closes #1124

Co-authored-by: Oleg Bespalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants