Enable forced deletion of GrafanaFolder
#1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess and
pb82
as code owners
|
I cannot replicate the test failures locally, will have to investigate this over the coming days. |
Baarsgaard
force-pushed
the
force_delete_folders
branch
from
1dd662a to
0a09ccf
Compare
|
I think that did it! |
Baarsgaard
force-pushed
the
force_delete_folders
branch
from
7e83618 to
b41a4a3
Compare
theSuess
force-pushed
the
force_delete_folders
branch
from
b41a4a3 to
7fa90c3
Compare
theSuess
approved these changes
Oct 28, 2024
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually the Grafana folder API will reject a
DELETEif the folder contains alert rules, this can be overwritten with theforceDeleteRules=truequery parameter.Which luckily is included in the Generated Grafana openapi client
This PR enables the forced deletion of folders specifically when declared with a CR.
Folders created from the
GrafanaDashboard#spec.folderfield are currently not forced as there is no CR declaring them.See: link
I spent 10 times as longer writing the tests for this new behaviour than the actual code.
Now there should be some a pretty extensive Chainsaw example snippets available for others in the future.
Additionally, I created an easy to use configuration for local testing in: ./tests/e2e/testdata-resources.yaml