Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Alert rule groups block deletion of folders when removed at the same time #1626

Closed
theSuess opened this issue Jul 30, 2024 · 1 comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@theSuess
Copy link
Member

Describe the bug
As folder deletion is not blocked with a finalizer it happens instantly. At this point, the finalizer is no longer able to find the folder and assumes there is nothing to clean up. This results in the folder never getting deleted from the instance

Version
master

To Reproduce
Steps to reproduce the behavior:

  1. Create an alert rule group & folder
  2. Delete both at the same time
  3. See that the resources are removed but still exist in grafana

Expected behavior
Folder deletion should block until removed from all instances

Suspect component/Location where the bug might be occurring
It's possible to work around this issue in the finalizer of the alert rule group. This however would be very complex as we'd have to re-parse the folders from the Grafana instance

@theSuess theSuess added bug Something isn't working needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 30, 2024
@theSuess
Copy link
Member Author

This is solved through #1728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

1 participant