fix(helm): allow setting pod labels #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #1538 landed, it's not possible to set additional pod labels. The only way of setting pod labels would be to change `grafana-operator.selectorLabels`, but doing that breaks current deployments as selector labels are immutable. `grafana-operator.labels` includes `grafana-operator.selectorLabels`, so it's safe to include them instead in the pod labels, and doing so fixes the current issue without causing side-effects. fixes #1546 #1642
pharaujo
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
|
|
theSuess
approved these changes
Aug 26, 2024
NissesSenap
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1538 landed, it's not possible to set additional pod labels. The only way of setting pod labels would be to change
grafana-operator.selectorLabels, but doing that breaks current deployments as selector labels are immutable.grafana-operator.labelsincludesgrafana-operator.selectorLabels, so it's safe to include them instead in the pod labels, and doing so fixes the current issue without causing side-effects as well as restores previous chart behavior.This is the alternative fix discussed in PR #1560
fixes #1546 #1642