Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deployment labels to use "grafana-operator.labels" instead of just "grafana-operator-labels.selectorLabels" #1546

Closed
David-John-Nintex opened this issue May 21, 2024 · 2 comments · Fixed by #1649
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@David-John-Nintex
Copy link

David-John-Nintex commented May 21, 2024

Is your feature request related to a problem? Please describe.
We have a set of labels that we need to apply to our cluster in order for our service to deploy (enforced by keda), and we would like to not have to disable these checks for this operator.

We have to keep a copy of your chart local and change the selectorLabels to labels to get the deployment to pass.

(If applicable)If your feature request solves a bug please provide a link to the community issue
No

Describe the solution you'd like
We would love a way to allow the user to select which set of labels to use for the deployment template, or alternatively use the labels as the default for the Pod

Describe alternatives you've considered
We are currently copying your template into our own private repo so we can update the labels field.

Additional context
We know our requirements are not to everyone's like, which is why I'm suggesting having a switch to allow one set of values or the other

Existing solutions
Not so much an existing solution, but something that's easy to implement

Proposed change
#1560

@David-John-Nintex David-John-Nintex added enhancement New feature or request needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 21, 2024
@theSuess theSuess added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 27, 2024
@theSuess
Copy link
Member

Thanks for the report!

Please create a PR with your recommended change - that way it's easier to discuss

@David-John-Nintex
Copy link
Author

Thanks for the report!

Please create a PR with your recommended change - that way it's easier to discuss

I have opened a new PR with my change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
2 participants