-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new configurable option to the windows installer for static mode #5958
Conversation
…ler for static mode Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
Signed-off-by: erikbaranowski <[email protected]>
Can we add a blurb on https://github.com/grafana/agent/blob/main/docs/sources/static/set-up/install/install-agent-on-windows.md about passing in the silent var? |
Signed-off-by: erikbaranowski <[email protected]>
|
||
The following options are available: | ||
|
||
- The [windows_exporter integration][windows_exporter_config] can be enabled with all default windows_exporter options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was hardcoded to /latest/ but should be corrected now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change to the wording
…e for expanding env vars (grafana#5958) * Add a new configurable option to the windows installer for static mode for expanding env vars Signed-off-by: erikbaranowski <[email protected]> * Update docs/sources/static/set-up/install/install-agent-on-windows.md Co-authored-by: Clayton Cornell <[email protected]> --------- Signed-off-by: erikbaranowski <[email protected]> Co-authored-by: Clayton Cornell <[email protected]>
PR Description
Closes #5554
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist