Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new configurable option to the windows installer for static mode #5958

Merged
merged 7 commits into from
Jan 10, 2024

Conversation

erikbaranowski
Copy link
Contributor

@erikbaranowski erikbaranowski commented Dec 11, 2023

PR Description

Closes #5554

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Signed-off-by: erikbaranowski <[email protected]>
@erikbaranowski erikbaranowski marked this pull request as ready for review January 4, 2024 19:58
@mattdurham
Copy link
Collaborator

Can we add a blurb on https://github.com/grafana/agent/blob/main/docs/sources/static/set-up/install/install-agent-on-windows.md about passing in the silent var?


The following options are available:

- The [windows_exporter integration][windows_exporter_config] can be enabled with all default windows_exporter options.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was hardcoded to /latest/ but should be corrected now

Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Jan 10, 2024
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to the wording

@erikbaranowski erikbaranowski changed the title first crack at adding a new configurable option to the windows instal… Add a new configurable option to the windows installer for static mode Jan 10, 2024
@erikbaranowski erikbaranowski enabled auto-merge (squash) January 10, 2024 19:57
@erikbaranowski erikbaranowski merged commit 38c8468 into main Jan 10, 2024
10 checks passed
@erikbaranowski erikbaranowski deleted the static-windows-installer-option branch January 10, 2024 20:02
BarunKGP pushed a commit to BarunKGP/grafana-agent that referenced this pull request Feb 20, 2024
…e for expanding env vars (grafana#5958)

* Add a new configurable option to the windows installer for static mode for expanding env vars 

Signed-off-by: erikbaranowski <[email protected]>

* Update docs/sources/static/set-up/install/install-agent-on-windows.md

Co-authored-by: Clayton Cornell <[email protected]>

---------

Signed-off-by: erikbaranowski <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let the windows installer create the service with the -config.expand-env parameter
3 participants