Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the windows installer create the service with the -config.expand-env parameter #5554

Closed
ToonTijtgat2 opened this issue Oct 20, 2023 · 5 comments · Fixed by #5958
Closed
Assignees
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@ToonTijtgat2
Copy link

Request

It would be nice if it's possible to run the windows installer of the grafana agent with a parameter to create the windows service with the -config.expand-env parameter

Use case

installing grafana agent on windows

Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Nov 20, 2023
@erikbaranowski erikbaranowski self-assigned this Dec 11, 2023
@erikbaranowski erikbaranowski removed the needs-attention An issue or PR has been sitting around and needs attention. label Dec 11, 2023
@erikbaranowski
Copy link
Contributor

I'm taking a look. This should be reasonable to do and see what the team thinks.

@erikbaranowski
Copy link
Contributor

I should mention... this is a static mode specific feature request as flow mode makes use of a standard library function and does not require a CLI flag for this functionality: https://grafana.com/docs/agent/next/flow/reference/stdlib/env/

@erikbaranowski
Copy link
Contributor

I have a draft PR #5958 and built the windows installer locally. I plan to keep playing around in January as I experiment with testing the windows installer locally to confirm it is working as intended

@dmitrydonskih
Copy link

@erikbaranowski could you also check "silent" installer mode?
Nullsoft installer allows unattended install/unninstall with /S parameter. No need to say how useful it is.
Customizable options should be available in this mode also, by command-line parameters.
Thanks for your work!

@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants