Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: partial docker syncTargets #5798

Merged
merged 3 commits into from
Dec 8, 2023
Merged

fix: partial docker syncTargets #5798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b172a5
fix: partial docker syncTargets
FerdinandvHagen Nov 17, 2023
f843d69
Add changelog entry
tpaschalis Dec 8, 2023
a304a05
Run gofmt -w -s
tpaschalis Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ Main (unreleased)

- Update `pyroscope.ebpf` to produce more optimal pprof profiles for python processes https://github.com/grafana/pyroscope/pull/2788 (@korniltsev)

- Fixes `loki.source.docker` a behavior that synced an incomplete list of targets to the tailer manager. (@FerdinandvHagen)

v0.38.1 (2023-11-30)
--------------------

Expand Down
6 changes: 3 additions & 3 deletions component/loki/source/docker/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,11 @@ func (c *Component) Update(args component.Arguments) error {
return err
}
targets = append(targets, tgt)

// This will never fail because it only fails if the context gets canceled.
_ = c.manager.syncTargets(context.Background(), targets)
}

// This will never fail because it only fails if the context gets canceled.
_ = c.manager.syncTargets(context.Background(), targets)

c.args = newArgs
return nil
}
Expand Down