fix: partial docker syncTargets #5798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rfratto
reviewed
Nov 27, 2023
syncTargets for docker is called within a loop which leads to an incomplete targets slice to be sent to the manager. Moving the syncTargets after the loop ensures that always all targets are correctly registered.
Signed-off-by: Paschalis Tsilias <[email protected]>
tpaschalis
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
LGTM! FYI @FerdinandvHagen I've rebased with main to avoid conflicts with the changelog and added a new bugfix entry.
Thanks for your contribution!
Signed-off-by: Paschalis Tsilias <[email protected]>
|
Thank you @tpaschalis - my pleasure. |
BarunKGP
pushed a commit
to BarunKGP/grafana-agent
that referenced
this pull request
Feb 20, 2024
* fix: partial docker syncTargets syncTargets for docker is called within a loop which leads to an incomplete targets slice to be sent to the manager. Moving the syncTargets after the loop ensures that always all targets are correctly registered. --------- Co-authored-by: Paschalis Tsilias <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syncTargets for docker is called within a loop which leads to an incomplete targets slice to be sent to the manager.
Moving the syncTargets after the loop ensures that always all targets are correctly registered.
PR Description
Which issue(s) this PR fixes
Fixes #5797
Notes to the Reviewer
PR Checklist