breaking change: rename discovery.file to local.file_match #4394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames discovery.file to local.file_match so that: * The purpose of the component is more clear (i.e., to find files on the local filesystem which match a given pattern). * To remove a point of confusion where `discovery.file` was thought to be Prometheus' file SD. * To allow a component for Prometheus' file SD to be named discovery.file, which otherwise would've collided with the now-named local.file_match. A redirect from the old documentation page is explicitly not configured because we anticipate creating a new page called discovery.file, which will have a warning about the rename. Related to grafana#3607.
captncraig
approved these changes
Jul 11, 2023
jcreixell
approved these changes
Jul 11, 2023
3 tasks
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
This commit renames discovery.file to local.file_match so that: * The purpose of the component is more clear (i.e., to find files on the local filesystem which match a given pattern). * To remove a point of confusion where `discovery.file` was thought to be Prometheus' file SD. * To allow a component for Prometheus' file SD to be named discovery.file, which otherwise would've collided with the now-named local.file_match. A redirect from the old documentation page is explicitly not configured because we anticipate creating a new page called discovery.file, which will have a warning about the rename. Related to #3607.
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
This commit renames discovery.file to local.file_match so that: * The purpose of the component is more clear (i.e., to find files on the local filesystem which match a given pattern). * To remove a point of confusion where `discovery.file` was thought to be Prometheus' file SD. * To allow a component for Prometheus' file SD to be named discovery.file, which otherwise would've collided with the now-named local.file_match. A redirect from the old documentation page is explicitly not configured because we anticipate creating a new page called discovery.file, which will have a warning about the rename. Related to #3607.
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames discovery.file to local.file_match so that:
The purpose of the component is more clear (i.e., to find files on the local filesystem which match a given pattern).
To remove a point of confusion where
discovery.filewas thought to be Prometheus' file SD.To allow a component for Prometheus' file SD to be named discovery.file, which otherwise would've collided with the now-named local.file_match.
A redirect from the old documentation page is explicitly not configured because we anticipate creating a new page called discovery.file, which will have a warning about the rename.
Related to #3607.