[Flow] Add new discovery.file component #4404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'discovery.file2'
spartan0x117
changed the title
captncraig
reviewed
Jul 12, 2023
| # discovery.file | ||
|
|
||
| > **NOTE:** In `v0.35.0` of the Grafana Agent, the `discovery.file` component was renamed to [local.file_match][]. From `v0.35.0` onwards, the `discovery.file` | ||
| > component behaves as documented here. |
There was a problem hiding this comment.
Maybe specify here briefly what local.file_match does, and why they may want to go there instead.
captncraig
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Code looks good to me. I'd say wait for @clayton-cornell to weigh in on docs.
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds the new
discovery.filecomponent, which implements Prometheus file-based SD.Note that there is a banner added to the new
discovery.filereference docs. Let me know if the wording should be changed or it should be moved elsewhere.Closes #3346
PR Checklist