added audioop-lts module to support pydub for python3.13+ #9757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/994c3ce18a2f4795c0a6878d7418faad1611a58d/gradio-5.3.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@994c3ce18a2f4795c0a6878d7418faad1611a58d#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/994c3ce18a2f4795c0a6878d7418faad1611a58d/gradio-client-1.7.0.tgzUse Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/994c3ce18a2f4795c0a6878d7418faad1611a58d/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
samy-FERGUI
force-pushed
the
fixing-bug
branch
from
c9efdfa to
ba5e6ca
Compare
|
Thanks @samy-FERGUI! It looks like we can revert your earlier changes in the docs about restricting Gradio to Python 3.12 and below, as part of this PR? |
|
@abidlabs indeed, we can revert the first commit now since we've solved the issue |
|
Could you do that as part of this PR please? Thanks! |
samy-FERGUI
force-pushed
the
fixing-bug
branch
from
7a8b81f to
e182bb1
Compare
|
@abidlabs done |
aliabid94
reviewed
Oct 21, 2024
| @@ -30,7 +30,7 @@ The Gradio client works with any hosted Gradio app! Although the Client is mostl | |||
|
|
|||
| If you already have a recent version of `gradio`, then the `gradio_client` is included as a dependency. But note that this documentation reflects the latest version of the `gradio_client`, so upgrade if you're not sure! | |||
|
|
|||
| The lightweight `gradio_client` package can be installed from pip (or pip3) and is tested to work with [**Python 3.10 - 3.12**]: | |||
| The lightweight `gradio_client` package can be installed from pip (or pip3) and is tested to work with **Python versions 3.9 or higher**: | |||
aliabid94
reviewed
Oct 21, 2024
requirements.txt
Outdated
| @@ -24,3 +24,4 @@ uvicorn>=0.14.0; sys.platform != 'emscripten' | |||
| typer>=0.12,<1.0; sys.platform != 'emscripten' | |||
| tomlkit==0.12.0 | |||
| ruff>=0.2.2; sys.platform != 'emscripten' | |||
| audioop-lts; python_version >= "3.13" #it provides support for 'audioop' module removed in latest python version used by pydub | |||
There was a problem hiding this comment.
this file seems to be in alphabetical order
aliabid94
approved these changes
Oct 21, 2024
|
@aliabid94 @abidlabs it was a pleasure to help ! |
samy-FERGUI
force-pushed
the
fixing-bug
branch
from
382fc6e to
adaae23
Compare
|
CI looks good, merging! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing the Gradio library locally, I encountered an issue where the audioop module has been removed in Python 3.13+, causing import errors within the pydub library. To address this, I added the audioop-lts module to provide support and resolve the issue.
Closes: #9696
🎯 PRs Should Target Issues
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh